This is an archive of the discontinued LLVM Phabricator instance.

[Alignment] Use Align for TargetLowering::MinStackArgumentAlignment
ClosedPublic

Authored by gchatelet on Sep 6 2019, 10:06 AM.

Details

Event Timeline

gchatelet created this revision.Sep 6 2019, 10:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2019, 10:06 AM
courbet added inline comments.Sep 9 2019, 2:41 AM
llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
1908–1909

I think what the code is trying to express here reads better as:

const MaybeAlign MaybeAlign
...
if (MaybeAlign && MaybeAlign.value() > TLI.getMinStackArgumentAlignment()) {
...
}

(same below)

gchatelet updated this revision to Diff 219493.Sep 10 2019, 1:51 AM
  • Address comments && rebase
courbet accepted this revision.Sep 10 2019, 1:53 AM
This revision is now accepted and ready to land.Sep 10 2019, 1:53 AM
This revision was automatically updated to reflect the committed changes.