Page MenuHomePhabricator

[Alignment] Use Align for TargetLowering::MinStackArgumentAlignment
ClosedPublic

Authored by gchatelet on Fri, Sep 6, 10:06 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

gchatelet created this revision.Fri, Sep 6, 10:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Sep 6, 10:06 AM
courbet added inline comments.Mon, Sep 9, 2:41 AM
llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
1908 ↗(On Diff #219300)

I think what the code is trying to express here reads better as:

const MaybeAlign MaybeAlign
...
if (MaybeAlign && MaybeAlign.value() > TLI.getMinStackArgumentAlignment()) {
...
}

(same below)

gchatelet updated this revision to Diff 219493.Tue, Sep 10, 1:51 AM
  • Address comments && rebase
courbet accepted this revision.Tue, Sep 10, 1:53 AM
This revision is now accepted and ready to land.Tue, Sep 10, 1:53 AM
This revision was automatically updated to reflect the committed changes.