Page MenuHomePhabricator

[lit] Only set DYLD_LIBRARY_PATH for shared builds
ClosedPublic

Authored by JDevlieghere on Aug 30 2019, 10:37 AM.

Details

Summary

In r370135 I committed a temporary workaround for the sanitized bot to not set (DY)LD_LIBRARY_PATH when (DY)LD_INSERT_LIBRARIES was set. Setting (DY)LD_LIBRARY_PATH is only necessary for (standalone) shared-library builds, so a better solution is to only set the environment variable when necessary.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Aug 30 2019, 10:37 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 30 2019, 10:37 AM
friss accepted this revision.Aug 30 2019, 3:25 PM

This looks good to me with one small provision:

lldb/lit/CMakeLists.txt
72 ↗(On Diff #218133)

The other booleans have names that match boolean values (_DISABLE_, _ENABLE_, _IS_). Should we rename this to something like LLVM_IS_SHARED_BUILD? I'm terrible at names.

This revision is now accepted and ready to land.Aug 30 2019, 3:25 PM
This revision was automatically updated to reflect the committed changes.