This is an archive of the discontinued LLVM Phabricator instance.

Differential D66910

[clangd] Fix ExtractFunction dependencies
ClosedPublic

Authored by aheejin on Aug 28 2019, 3:48 PM.

Details

Reviewers
SureYeaah
Commits
rG660efa596f6b: [clangd] Fix ExtractFunction dependencies
rCTE370273: [clangd] Fix ExtractFunction dependencies
rL370273: [clangd] Fix ExtractFunction dependencies
Summary

Without these dependencies, builds with -DBUILD_SHARED_LIBS=ON fail.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Aug 28 2019, 3:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2019, 3:48 PM
Herald added subscribers: cfe-commits, kadircet, arphaman and 4 others. · View Herald Transcript
Harbormaster completed remote builds in B37462: Diff 217733.Aug 28 2019, 3:50 PM
SureYeaah accepted this revision.Aug 28 2019, 4:10 PM
This revision is now accepted and ready to land.Aug 28 2019, 4:10 PM
Closed by commit rL370273: [clangd] Fix ExtractFunction dependencies (authored by aheejin). · Explain WhyAug 28 2019, 4:18 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 28 2019, 4:18 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
clang-tools-extra/
trunk/
clangd/
refactor/
tweaks/
1 line
tool/
1 line
unittests/
1 line

Diff 217736

clang-tools-extra/trunk/clangd/refactor/tweaks/CMakeLists.txt

Show All 20 Linesadd_clang_library(clangDaemonTweaks OBJECT
RawStringLiteral.cpp RawStringLiteral.cpp
SwapIfBranches.cpp SwapIfBranches.cpp
LINK_LIBS LINK_LIBS
clangAST clangAST
clangBasic clangBasic
clangDaemon clangDaemon
clangToolingCore clangToolingCore
clangToolingRefactoring
clangToolingSyntax clangToolingSyntax
) )

clang-tools-extra/trunk/clangd/tool/CMakeLists.txt

Show All 20 Linestarget_link_libraries(clangd
clangBasic clangBasic
clangTidy clangTidy
clangDaemon clangDaemon
clangFormat clangFormat
clangFrontend clangFrontend
clangSema clangSema
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingRefactoring
clangToolingSyntax clangToolingSyntax
${CLANGD_XPC_LIBS} ${CLANGD_XPC_LIBS}
) )

clang-tools-extra/trunk/clangd/unittests/CMakeLists.txt

Show First 20 Lines • Show All 84 Lines • ▼ Show 20 Linestarget_link_libraries(ClangdTests
clangIndex clangIndex
clangLex clangLex
clangSema clangSema
clangSerialization clangSerialization
clangTidy clangTidy
clangTooling clangTooling
clangToolingCore clangToolingCore
clangToolingInclusions clangToolingInclusions
clangToolingRefactoring
clangToolingSyntax clangToolingSyntax
LLVMSupport LLVMSupport
LLVMTestingSupport LLVMTestingSupport
) )
if (CLANGD_BUILD_XPC) if (CLANGD_BUILD_XPC)
add_subdirectory(xpc) add_subdirectory(xpc)
endif () endif ()
configure_lit_site_cfg( configure_lit_site_cfg(
${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.py.in
${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py) ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg.py)