Page MenuHomePhabricator
People SureYeaah

SureYeaah (Shaurya Gupta)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 11 2019, 2:54 AM (207 w, 3 d)

Recent Activity
View All

Mar 18 2021

SureYeaah added a comment to D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver.

We are seeing some internal breakage in google because CLANG_DEFAULT_LINKER is set to ld. It would be nice to make the tests more tolerant.

Mar 18 2021, 3:51 AM · Restricted Project
SureYeaah added a comment to D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver.

What if CLANG_DEFAULT_LINKER=ld?

Mar 18 2021, 3:39 AM · Restricted Project

Jan 28 2021

SureYeaah added a comment to D95622: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".

Here's the stacktrace from a crash:

Jan 28 2021, 8:44 AM · Restricted Project
SureYeaah added a reverting change for rGef0dcb506300: [DWARF] Create subprogram's DIE in DISubprogram's unit: rGe29552c5aff6: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".
Jan 28 2021, 8:40 AM
SureYeaah committed rGe29552c5aff6: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit" (authored by SureYeaah).
Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit"
Jan 28 2021, 8:40 AM
SureYeaah added a reverting change for D94976: [DWARF] Create subprogram's DIE in the unit specified by its DISubprogram: rGe29552c5aff6: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".
Jan 28 2021, 8:40 AM · Restricted Project
SureYeaah closed D95622: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".
Jan 28 2021, 8:40 AM · Restricted Project
SureYeaah updated subscribers of D95622: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".

cc: @jmorse

Jan 28 2021, 8:25 AM · Restricted Project
SureYeaah added a comment to D95622: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".

I am trying to create a small repro for this that I can share but it would be great if we could revert this asap.

Jan 28 2021, 8:23 AM · Restricted Project
SureYeaah added a reverting change for rGef0dcb506300: [DWARF] Create subprogram's DIE in DISubprogram's unit: D95622: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".
Jan 28 2021, 8:22 AM
SureYeaah added a reverting change for D94976: [DWARF] Create subprogram's DIE in the unit specified by its DISubprogram: D95622: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".
Jan 28 2021, 8:22 AM · Restricted Project
SureYeaah requested review of D95622: Revert "[DWARF] Create subprogram's DIE in DISubprogram's unit".
Jan 28 2021, 8:22 AM · Restricted Project

Dec 31 2020

SureYeaah added a reverting change for rG6f1503d59854: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops: rG8bee4d4e8f54: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….
Dec 31 2020, 3:48 AM
SureYeaah committed rG8bee4d4e8f54: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free… (authored by bgraur).
Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free…
Dec 31 2020, 3:48 AM
SureYeaah added a reverting change for D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops: rG8bee4d4e8f54: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free….
Dec 31 2020, 3:48 AM · Restricted Project, Restricted Project, Restricted Project
SureYeaah closed D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops".
Dec 31 2020, 3:48 AM · Restricted Project, Restricted Project
SureYeaah added a reverting change for rG52aa4e210744: [ThinLTO][test] Add visibility related tests: rGbe764065beb2: Revert "[ThinLTO][test] Add visibility related tests".
Dec 31 2020, 3:46 AM
SureYeaah committed rGbe764065beb2: Revert "[ThinLTO][test] Add visibility related tests" (authored by bgraur).
Revert "[ThinLTO][test] Add visibility related tests"
Dec 31 2020, 3:46 AM
SureYeaah added a reverting change for D92899: [ThinLTO][test] Add visibility related tests: rGbe764065beb2: Revert "[ThinLTO][test] Add visibility related tests".
Dec 31 2020, 3:46 AM · Restricted Project
SureYeaah closed D93957: Revert "[ThinLTO][test] Add visibility related tests".
Dec 31 2020, 3:45 AM · Restricted Project
SureYeaah accepted D93957: Revert "[ThinLTO][test] Add visibility related tests".
Dec 31 2020, 3:37 AM · Restricted Project
SureYeaah accepted D93956: Revert "[LoopDeletion] Allows deletion of possibly infinite side-effect free loops".
Dec 31 2020, 3:37 AM · Restricted Project, Restricted Project

Dec 28 2020

SureYeaah accepted D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".
Dec 28 2020, 7:57 AM · Restricted Project
SureYeaah requested changes to D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".
Dec 28 2020, 7:57 AM · Restricted Project
SureYeaah updated subscribers of D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".
Dec 28 2020, 5:16 AM · Restricted Project
SureYeaah accepted D93857: Revert "[InstCombine] Hoist xor-by-constant from xor-by-value".

LGTM

Dec 28 2020, 5:15 AM · Restricted Project

Oct 2 2019

SureYeaah committed rGa24762e773d9: [Clangd] ExtractFunction: Don't extract body of enclosing function. (authored by SureYeaah).
[Clangd] ExtractFunction: Don't extract body of enclosing function.
Oct 2 2019, 6:57 AM
SureYeaah committed rGf1758079540c: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153) (authored by SureYeaah).
[Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)
Oct 2 2019, 6:51 AM
SureYeaah committed rL373472: [Clangd] ExtractFunction: Don't extract body of enclosing function..
[Clangd] ExtractFunction: Don't extract body of enclosing function.
Oct 2 2019, 6:51 AM
SureYeaah closed D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function..
Oct 2 2019, 6:51 AM · Restricted Project, Restricted Project
SureYeaah committed rL373471: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153).
[Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153)
Oct 2 2019, 6:49 AM
SureYeaah closed D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153).
Oct 2 2019, 6:49 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function..

Added assert and removed fixme

Oct 2 2019, 6:13 AM · Restricted Project, Restricted Project

Oct 1 2019

SureYeaah updated the diff for D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153).

Address review comments

Oct 1 2019, 3:57 AM · Restricted Project, Restricted Project

Sep 30 2019

SureYeaah created D68245: [Clangd] ExtractFunction: Don't extract body of enclosing function..
Sep 30 2019, 3:07 PM · Restricted Project, Restricted Project
SureYeaah updated the diff for D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153).

Moved Unittest

Sep 30 2019, 2:23 PM · Restricted Project, Restricted Project

Sep 28 2019

SureYeaah updated the diff for D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153).

Added llmv_unreachable

Sep 28 2019, 8:16 AM · Restricted Project, Restricted Project
SureYeaah created D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153).
Sep 28 2019, 8:08 AM · Restricted Project, Restricted Project
SureYeaah updated the summary of D68182: [Clangd] Ensure children are always RootStmt in ExtractFunction (Fixes #153).
Sep 28 2019, 8:08 AM · Restricted Project, Restricted Project
SureYeaah accepted D66872: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed..

Sorry about the delay. LGTM. Thanks!

Sep 28 2019, 5:56 AM · Restricted Project, Restricted Project

Sep 23 2019

SureYeaah committed rG7e56dd0229f8: [Clang-doc] NFC: Fixed link to llvm bugs in documentation (authored by SureYeaah).
[Clang-doc] NFC: Fixed link to llvm bugs in documentation
Sep 23 2019, 9:55 AM
SureYeaah committed rL372627: [Clang-doc] NFC: Fixed link to llvm bugs in documentation.
[Clang-doc] NFC: Fixed link to llvm bugs in documentation
Sep 23 2019, 9:53 AM

Aug 30 2019

SureYeaah committed rG3b08a61f7e81: [Clangd] ExtractFunction Added checks for broken control flow (authored by SureYeaah).
[Clangd] ExtractFunction Added checks for broken control flow
Aug 30 2019, 2:58 AM
SureYeaah committed rL370455: [Clangd] ExtractFunction Added checks for broken control flow.
[Clangd] ExtractFunction Added checks for broken control flow
Aug 30 2019, 2:56 AM
SureYeaah closed D66732: [Clangd] ExtractFunction Added checks for broken control flow.
Aug 30 2019, 2:56 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D66732: [Clangd] ExtractFunction Added checks for broken control flow.

Addressed review comments

Aug 30 2019, 2:56 AM · Restricted Project, Restricted Project

Aug 29 2019

SureYeaah committed rG6a801454f16a: [Clangd] NFC: Added fixme for checking for local/anonymous types for extracted… (authored by SureYeaah).
[Clangd] NFC: Added fixme for checking for local/anonymous types for extracted…
Aug 29 2019, 8:16 AM
SureYeaah committed rL370372: [Clangd] NFC: Added fixme for checking for local/anonymous types for extracted….
[Clangd] NFC: Added fixme for checking for local/anonymous types for extracted…
Aug 29 2019, 8:16 AM
SureYeaah updated the diff for D66732: [Clangd] ExtractFunction Added checks for broken control flow.

Added null statement check in TraverseStmt

Aug 29 2019, 7:53 AM · Restricted Project, Restricted Project
SureYeaah updated the summary of D66732: [Clangd] ExtractFunction Added checks for broken control flow.
Aug 29 2019, 7:02 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D66732: [Clangd] ExtractFunction Added checks for broken control flow.

Removed selectionTree Visitor

Aug 29 2019, 7:02 AM · Restricted Project, Restricted Project

Aug 28 2019

SureYeaah accepted D66910: [clangd] Fix ExtractFunction dependencies.
Aug 28 2019, 4:11 PM · Restricted Project, Restricted Project
SureYeaah committed rGbf4773485e0f: [Clangd] Initial version of ExtractFunction (authored by SureYeaah).
[Clangd] Initial version of ExtractFunction
Aug 28 2019, 12:36 PM
SureYeaah committed rL370249: [Clangd] Initial version of ExtractFunction.
[Clangd] Initial version of ExtractFunction
Aug 28 2019, 12:36 PM
SureYeaah closed D65526: [Clangd] First version of ExtractFunction.
Aug 28 2019, 12:36 PM · Restricted Project, Restricted Project
SureYeaah added inline comments to D65526: [Clangd] First version of ExtractFunction.
Aug 28 2019, 12:32 PM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Addressed review comments

Aug 28 2019, 12:32 PM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

NFC: Whitespace formatting

Aug 28 2019, 6:21 AM · Restricted Project, Restricted Project
SureYeaah added inline comments to D65526: [Clangd] First version of ExtractFunction.
Aug 28 2019, 6:21 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Addressed review comments

Aug 28 2019, 6:17 AM · Restricted Project, Restricted Project

Aug 26 2019

SureYeaah created D66732: [Clangd] ExtractFunction Added checks for broken control flow.
Aug 26 2019, 4:20 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Fixed typo

Aug 26 2019, 3:46 AM · Restricted Project, Restricted Project

Aug 23 2019

SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Removed extra code

Aug 23 2019, 6:55 AM · Restricted Project, Restricted Project
SureYeaah added inline comments to D65526: [Clangd] First version of ExtractFunction.
Aug 23 2019, 6:07 AM · Restricted Project, Restricted Project
SureYeaah added inline comments to D65526: [Clangd] First version of ExtractFunction.
Aug 23 2019, 6:02 AM · Restricted Project, Restricted Project
SureYeaah retitled D65526: [Clangd] First version of ExtractFunction from [Clangd] Initial prototype version of ExtractFunction to [Clangd] First version of ExtractFunction.
Aug 23 2019, 5:58 AM · Restricted Project, Restricted Project
SureYeaah accepted D66590: [clangd] Fix toHalfOpenFileRange where start/end endpoints are in different files due to #include.

LGTM

Aug 23 2019, 5:49 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Addressed more review comments

Aug 23 2019, 4:26 AM · Restricted Project, Restricted Project

Aug 22 2019

SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Addressed Review comments

Aug 22 2019, 10:50 AM · Restricted Project, Restricted Project
SureYeaah committed rG1a28a06ebef2: [Clangd] Tweaktesting replace toString with consumeError (authored by SureYeaah).
[Clangd] Tweaktesting replace toString with consumeError
Aug 22 2019, 10:38 AM
SureYeaah committed rL369676: [Clangd] Tweaktesting replace toString with consumeError.
[Clangd] Tweaktesting replace toString with consumeError
Aug 22 2019, 10:38 AM
SureYeaah committed rG5ee01ef1e532: Fixed Missing Expected error handling (authored by SureYeaah).
Fixed Missing Expected error handling
Aug 22 2019, 9:43 AM
SureYeaah committed rL369666: Fixed Missing Expected error handling.
Fixed Missing Expected error handling
Aug 22 2019, 9:43 AM

Aug 16 2019

SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Fixed semicolon bug

Aug 16 2019, 9:02 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Fixed bug in getLocType

Aug 16 2019, 6:08 AM · Restricted Project, Restricted Project

Aug 14 2019

SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Better Naming

Aug 14 2019, 8:32 AM · Restricted Project, Restricted Project
SureYeaah committed rG36ca1e6399fe: [Tooling] Added DeclStmtClass to ExtractionSemicolonPolicy (authored by SureYeaah).
[Tooling] Added DeclStmtClass to ExtractionSemicolonPolicy
Aug 14 2019, 6:38 AM
SureYeaah committed rL368850: [Tooling] Added DeclStmtClass to ExtractionSemicolonPolicy.
[Tooling] Added DeclStmtClass to ExtractionSemicolonPolicy
Aug 14 2019, 6:37 AM
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Removed debug info

Aug 14 2019, 6:00 AM · Restricted Project, Restricted Project
SureYeaah committed rGd81a8698762b: [Clangd] NFC: Fixed comment typo (authored by SureYeaah).
[Clangd] NFC: Fixed comment typo
Aug 14 2019, 5:42 AM
SureYeaah committed rL368841: [Clangd] NFC: Fixed comment typo.
[Clangd] NFC: Fixed comment typo
Aug 14 2019, 5:41 AM
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Removed unrelated changes

Aug 14 2019, 5:38 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65526: [Clangd] First version of ExtractFunction.

Refactored design and added unit tests.

Aug 14 2019, 4:02 AM · Restricted Project, Restricted Project

Aug 13 2019

SureYeaah committed rG52d0cfc91e07: [Refactor] Moving SourceExtraction header from lib to include (authored by SureYeaah).
[Refactor] Moving SourceExtraction header from lib to include
Aug 13 2019, 1:22 PM
SureYeaah committed rL368743: [Refactor] Moving SourceExtraction header from lib to include.
[Refactor] Moving SourceExtraction header from lib to include
Aug 13 2019, 1:20 PM
SureYeaah closed D65878: [Refactor] Moving SourceExtraction header from lib to include.
Aug 13 2019, 1:20 PM · Restricted Project, Restricted Project

Aug 12 2019

SureYeaah added a reviewer for D65878: [Refactor] Moving SourceExtraction header from lib to include: teemperor.
Aug 12 2019, 3:38 AM · Restricted Project, Restricted Project

Aug 8 2019

SureYeaah committed rG7137736e49ce: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase (authored by SureYeaah).
[Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase
Aug 8 2019, 1:38 AM
SureYeaah committed rL368267: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase.
[Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase
Aug 8 2019, 1:38 AM
SureYeaah closed D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase.
Aug 8 2019, 1:38 AM · Restricted Project, Restricted Project

Aug 7 2019

SureYeaah updated the diff for D65878: [Refactor] Moving SourceExtraction header from lib to include.

Added endif comment

Aug 7 2019, 12:58 PM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase.

Added tests

Aug 7 2019, 9:24 AM · Restricted Project, Restricted Project
SureYeaah retitled D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase from [Extract] Fixed SemicolonExtractionPolicy for Do and Switch Stmt to [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase.
Aug 7 2019, 8:34 AM · Restricted Project, Restricted Project
SureYeaah updated the diff for D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase.

Removed Do

Aug 7 2019, 8:34 AM · Restricted Project, Restricted Project
SureYeaah created D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase.
Aug 7 2019, 8:20 AM · Restricted Project, Restricted Project
SureYeaah updated the summary of D65878: [Refactor] Moving SourceExtraction header from lib to include.
Aug 7 2019, 8:10 AM · Restricted Project, Restricted Project
SureYeaah created D65878: [Refactor] Moving SourceExtraction header from lib to include.
Aug 7 2019, 8:09 AM · Restricted Project, Restricted Project

Aug 6 2019

SureYeaah committed rG8fbb6ce84782: Fixed toHalfOpenFileRange assertion fail (authored by SureYeaah).
Fixed toHalfOpenFileRange assertion fail
Aug 6 2019, 10:02 AM
SureYeaah committed rL368058: Fixed toHalfOpenFileRange assertion fail.
Fixed toHalfOpenFileRange assertion fail
Aug 6 2019, 10:02 AM
SureYeaah closed D65754: Fix toHalfOpenFileRange assertion fail.
Aug 6 2019, 10:02 AM · Restricted Project, Restricted Project