Page MenuHomePhabricator

[llvm-objdump] Add the missing ARMv8 subarch detection
ClosedPublic

Authored by kongyi on Aug 27 2019, 5:33 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

kongyi created this revision.Aug 27 2019, 5:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2019, 5:33 PM
MaskRay added inline comments.Aug 27 2019, 7:48 PM
llvm/lib/Object/ELFObjectFile.cpp
360 ↗(On Diff #217540)

Is "v8a" better?

There are a few other v8 build attributes:

v8_R     = 15,  // e.g. Cortex R52
v8_M_Base= 16,  // v8_M_Base AArch32
v8_M_Main= 17,  // v8_M_Main AArch32
v8_1_M_Main=21, // v8_1_M_Main AArch32

Should they be listed as well?

kongyi updated this revision to Diff 217571.Aug 27 2019, 8:47 PM
kongyi marked an inline comment as done.

I don't know what new instructions are introduced only in v8.1m-main, omitted the tests (it's not that interesting anyway).

MaskRay accepted this revision.Aug 27 2019, 11:28 PM
This revision is now accepted and ready to land.Aug 27 2019, 11:28 PM
This revision was automatically updated to reflect the committed changes.