Page MenuHomePhabricator

[x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32
ClosedPublic

Authored by yubing on Aug 26 2019, 11:24 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

yubing created this revision.Aug 26 2019, 11:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2019, 11:24 PM
RKSimon added inline comments.Aug 27 2019, 5:42 AM
clang/lib/Headers/avx512fintrin.h
9662 ↗(On Diff #217314)

Since we're adding this, we should set an example and include the doxygen comment as well (even though avx512 intrinsics aren't well documented). You should be able to copy the doxygen from _mm_cvtsi128_si32 in emmintrin.h with only trivial edits

clang/test/CodeGen/avx512f-builtins.c
10849 ↗(On Diff #217314)

Put in alphabetical order? I make that just after test_mm_cvtsd_u32 ?

yubing marked 2 inline comments as done.Aug 28 2019, 8:00 PM
yubing added inline comments.
clang/lib/Headers/avx512fintrin.h
9662 ↗(On Diff #217314)

Thanks for comments, I will fix them

clang/test/CodeGen/avx512f-builtins.c
10849 ↗(On Diff #217314)

Do we really need to put them in alphabetical order?
It seems testcases in this file are out of order.

yubing updated this revision to Diff 217764.Aug 28 2019, 8:12 PM
craig.topper added inline comments.Aug 28 2019, 9:50 PM
clang/lib/Headers/avx512fintrin.h
9669 ↗(On Diff #217764)

__A

yubing updated this revision to Diff 217774.Aug 28 2019, 10:01 PM
yubing marked an inline comment as done.
yubing marked 2 inline comments as done.Aug 28 2019, 10:03 PM
This revision is now accepted and ready to land.Aug 28 2019, 10:15 PM
This revision was automatically updated to reflect the committed changes.