Page MenuHomePhabricator

[DAGCombiner] Add node to the worklist in topological order in scalarizeExtractedVectorLoad
AcceptedPublic

Authored by deadalnix on Fri, Aug 23, 8:49 AM.

Details

Summary

As per title.

Diff Detail

Event Timeline

deadalnix created this revision.Fri, Aug 23, 8:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Aug 23, 8:49 AM
lebedev.ri added inline comments.Fri, Aug 23, 11:10 AM
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
16639

Won't this cause the node to be revisited, before AddToWorklist(EVE); ?

deadalnix marked 2 inline comments as done.Fri, Aug 23, 12:06 PM
deadalnix added inline comments.
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
1696

When the node itself is returned, it is not added back to the worklist.

16639

No. The only difference between this and just returning an empty value is that it increment the counter of transform that has been done. The main loop assumes that whatever transform does this has handled the worklist properly.

This revision is now accepted and ready to land.Sun, Sep 15, 12:16 PM
RKSimon accepted this revision.Sun, Sep 15, 1:44 PM

LGTM