This diff contains the sum of changes of UBSan, LSan and ASan in the
Emscripten repository.
Details
- Reviewers
jfb
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 37087 Build 37086: arc lint + arc unit
Event Timeline
compiler-rt/lib/lsan/lsan_common.cpp | ||
---|---|---|
173 | Why not combine this block with the block below that looks like the only user of cache_begin, cache_end? Also the comment looks incorrectly indented. | |
compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cpp | ||
21 | Perhaps worth putting these emscripten_builtin_ functions in the header file and then #include <emscripten/foo.h> here and elsewhere rather than forward declaring them? | |
21 | Same with emscripten_get_module_name.. they could maybe go in <emscripten/internal.h> for want of a better name? Or maybe <emscripoten/jsapi.h>`? |
compiler-rt/lib/asan/asan_flags.cpp | ||
---|---|---|
28 | It might be worth tucking these conditional imports away in a more isolated location. Where do other platforms put this kind of stuff? |
It might be worth tucking these conditional imports away in a more isolated location. Where do other platforms put this kind of stuff?