This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add Emscripten support for UBSan, LSan and ASan
Changes PlannedPublic

Authored by quantum on Aug 21 2019, 11:15 AM.

Details

Reviewers
jfb
Summary

This diff contains the sum of changes of UBSan, LSan and ASan in the
Emscripten repository.

Event Timeline

quantum created this revision.Aug 21 2019, 11:15 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, Restricted Project, jfb and 8 others. · View Herald Transcript
quantum planned changes to this revision.Aug 21 2019, 11:16 AM
sbc100 added inline comments.Aug 21 2019, 11:37 AM
compiler-rt/lib/lsan/lsan_common.cpp
173

Why not combine this block with the block below that looks like the only user of cache_begin, cache_end?

Also the comment looks incorrectly indented.

compiler-rt/lib/sanitizer_common/sanitizer_flag_parser.cpp
21

Perhaps worth putting these emscripten_builtin_ functions in the header file and then #include <emscripten/foo.h> here and elsewhere rather than forward declaring them?

21

Same with emscripten_get_module_name.. they could maybe go in <emscripten/internal.h> for want of a better name? Or maybe <emscripoten/jsapi.h>`?

tlively added inline comments.Aug 22 2019, 11:45 AM
compiler-rt/lib/asan/asan_flags.cpp
28

It might be worth tucking these conditional imports away in a more isolated location. Where do other platforms put this kind of stuff?