Page MenuHomePhabricator

[DAGCombiner] Remove mostly redundant calls to AddToWorklist
ClosedPublic

Authored by deadalnix on Aug 21 2019, 10:40 AM.

Details

Summary

These calls change the order in which some nodes are processed and so have an effect on codegen.

The change in fixup-bw-copy.ll is due to (and (load anyext)) gets transformed into (load zext) while previously the and was removed by SimplifyDemandedBits, so the (load anyext) remained.

Diff Detail

Repository
rL LLVM

Event Timeline

deadalnix created this revision.Aug 21 2019, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 21 2019, 10:40 AM
deadalnix retitled this revision from [DAGCombiner] Remove ostl redundant calls to AddToWorklist to [DAGCombiner] Remove mostly redundant calls to AddToWorklist.Aug 21 2019, 10:43 AM
efriedma accepted this revision.Aug 21 2019, 11:39 AM

These are redundant because they're new nodes? Sure, LGTM.

This revision is now accepted and ready to land.Aug 21 2019, 11:39 AM

They are indeed new nodes that end up being added to the worklist when their user is processed.

This revision was automatically updated to reflect the committed changes.