Page MenuHomePhabricator

[Syntax] Added function to get macro expansion tokens to TokenBuffer.
ClosedPublic

Authored by jvikstrom on Aug 20 2019, 4:57 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

jvikstrom created this revision.Aug 20 2019, 4:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2019, 4:57 AM
jvikstrom updated this revision to Diff 216103.Aug 20 2019, 4:58 AM

Readded dissapeared newline.

ilya-biryukov accepted this revision.Aug 20 2019, 6:01 AM

LGTM

clang/include/clang/Tooling/Syntax/Tokens.h
239 ↗(On Diff #216103)

NIT: add the doxygen tag for parameter in \p FID

245 ↗(On Diff #216103)

NIT: FOO and FOO2 are also mentioned in the #define lines. Maybe clarify that the results are at lines 3 and 5, not 1 and 2?

This revision is now accepted and ready to land.Aug 20 2019, 6:01 AM
This revision was automatically updated to reflect the committed changes.
jvikstrom marked 2 inline comments as done.
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2019, 6:33 AM