Page MenuHomePhabricator

Fix nm on GCC 5.1 after the C++14 move
ClosedPublic

Authored by jfb on Aug 15 2019, 1:15 PM.

Details

Summary

As in D66306, fix the invocation of std::sort with std::function by not using
std::function, since it's easier to read and is broken in libstdc++ from GCC 5.1
(see https://gcc.gnu.org/PR65942).

Diff Detail

Repository
rL LLVM

Event Timeline

jfb created this revision.Aug 15 2019, 1:15 PM
thakis accepted this revision.Aug 15 2019, 1:32 PM

Thanks again!

llvm/tools/llvm-nm/llvm-nm.cpp
717 ↗(On Diff #215460)

Nit: I find the staggered if on the lhs easier to readh than the nested ternary

This revision is now accepted and ready to land.Aug 15 2019, 1:32 PM
jfb updated this revision to Diff 215464.Aug 15 2019, 1:37 PM
  • Use if instead of ternary
This revision was automatically updated to reflect the committed changes.
jfb marked an inline comment as done.Aug 15 2019, 1:37 PM

Sounds like you get to claim this as a fix for https://bugs.llvm.org/show_bug.cgi?id=24115 too :)

jfb added a comment.Aug 15 2019, 2:10 PM

Sounds like you get to claim this as a fix for https://bugs.llvm.org/show_bug.cgi?id=24115 too :)

Sounds about right, thanks for pointing this out. I've closed the bug.