Page MenuHomePhabricator

[CMake] Check for C++14 instead of C++11
ClosedPublic

Authored by JDevlieghere on Aug 14 2019, 8:13 PM.

Details

Summary

Now that LLVM moved to C++14, I suspect that COMPILER_RT_HAS_STD_CXX11_FLAG should become COMPILER_RT_HAS_STD_CXX14_FLAG.

I ran into this issue when replacing llvm::make_unique with std::make_unique in an X-ray unit test. We are correctly passing -std=c++14, but further down in the invocation it was being overriding because we are passing -std=c++11. Given that this unit test is using LLVM headers, this is bound to break sooner than later, regardless of my change.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Aug 14 2019, 8:13 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 14 2019, 8:13 PM
Herald added subscribers: Restricted Project, dexonsmith, mgorny. · View Herald Transcript
phosek accepted this revision.Aug 14 2019, 9:30 PM

LGTM

This revision is now accepted and ready to land.Aug 14 2019, 9:30 PM
This revision was automatically updated to reflect the committed changes.
jfb added a comment.Aug 15 2019, 9:07 AM

Thanks for fixing this!