[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛

[stephanemoore]

Summary

This migrates objc-forbidden-subclassing to isDerivedFrom as it now
supports matching Objective-C interface declarations.

Test Notes:
Ran clang tools tests.

[aaron.ballman]

LGTM!

[gribozavr]

LGTM, thanks!

clang-tools-extra/trunk/clang-tidy/objc/ForbiddenSubclassingCheck.cpp

constexpr char DefaultForbiddenSuperClassNames[] =
     "NSPointerFunctions;"
     "NSTimer;"
     "UIActionSheet;"
     "UIAlertView;"
     "UIImagePickerController;"
     "UITextInputMode;"
     "UIWebView";
 
-/// \brief Matches Objective-C classes that directly or indirectly
-/// have a superclass matching \c Base.
-///
-/// Note that a class is not considered to be a subclass of itself.
-///
-/// Example matches Y, Z
-/// (matcher = objcInterfaceDecl(hasName("X")))
-/// \code
-///   @interface X
-///   @end
-///   @interface Y : X  // directly derived
-///   @end
-///   @interface Z : Y  // indirectly derived
-///   @end
-/// \endcode
-AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOf,
-              ast_matchers::internal::Matcher<ObjCInterfaceDecl>, Base) {
-  for (const auto *SuperClass = Node.getSuperClass();
-       SuperClass != nullptr;
-       SuperClass = SuperClass->getSuperClass()) {
-    if (Base.matches(*SuperClass, Finder, Builder)) {
-      return true;
-    }
-  }
-  return false;
-}
-
 } // namespace
 
 ForbiddenSubclassingCheck::ForbiddenSubclassingCheck(
     StringRef Name,
     ClangTidyContext *Context)
     : ClangTidyCheck(Name, Context),
       ForbiddenSuperClassNames(
           utils::options::parseStringList(
               Options.get("ClassNames", DefaultForbiddenSuperClassNames))) {
 }
 
 void ForbiddenSubclassingCheck::registerMatchers(MatchFinder *Finder) {
   // this check should only be applied to ObjC sources.
   if (!getLangOpts().ObjC)
     return;
 
   Finder->addMatcher(
       objcInterfaceDecl(
-          isSubclassOf(
+          isDerivedFrom(
               objcInterfaceDecl(
                   hasAnyName(
                       std::vector<StringRef>(
                           ForbiddenSuperClassNames.begin(),
                           ForbiddenSuperClassNames.end())))
               .bind("superclass")))
       .bind("subclass"),
       this);