Page MenuHomePhabricator

[AArch64][GlobalISel] Legalize 128 bit divisions to libcalls
AcceptedPublic

Authored by aemerson on Tue, Aug 13, 3:52 PM.

Details

Reviewers
paquette
Summary

Now that we have the infrastructure to support s128 types as parameters we can expand these to libcalls.

Diff Detail

Event Timeline

aemerson created this revision.Tue, Aug 13, 3:52 PM
paquette added inline comments.Tue, Aug 13, 4:01 PM
llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp
2959–2960

I think that you need braces around the WideTy.isVector() || WideTy == LLT::Scalar(128) here, because && has higher precedence than ||.

aemerson updated this revision to Diff 214971.Tue, Aug 13, 4:26 PM

Fix assertion expression.

This revision is now accepted and ready to land.Tue, Aug 13, 4:37 PM