Page MenuHomePhabricator

[AArch64][GlobalISel] Legalize 128 bit divisions to libcalls
ClosedPublic

Authored by aemerson on Aug 13 2019, 3:52 PM.

Details

Summary

Now that we have the infrastructure to support s128 types as parameters we can expand these to libcalls.

Diff Detail

Repository
rL LLVM

Event Timeline

aemerson created this revision.Aug 13 2019, 3:52 PM
paquette added inline comments.Aug 13 2019, 4:01 PM
llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp
2959–2960 ↗(On Diff #214959)

I think that you need braces around the WideTy.isVector() || WideTy == LLT::Scalar(128) here, because && has higher precedence than ||.

aemerson updated this revision to Diff 214971.Aug 13 2019, 4:26 PM

Fix assertion expression.

This revision is now accepted and ready to land.Aug 13 2019, 4:37 PM
This revision was automatically updated to reflect the committed changes.