Page MenuHomePhabricator

[Attributor] Use the AANoNull attribute directly in AADereferenceable
ClosedPublic

Authored by jdoerfert on Mon, Aug 12, 3:09 PM.

Details

Summary

Instead of constantly keeping track of the nonnull status with the
dereferenceable information we can simply query the nonnull attribute
whenever we need the information (debug + manifest).

Diff Detail

Repository
rL LLVM

Event Timeline

jdoerfert created this revision.Mon, Aug 12, 3:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Aug 12, 3:09 PM
uenoku accepted this revision.Mon, Aug 12, 9:00 PM

I think it is better to use intersectAssumedBits for BooleanState.
Otherwise, LGTM.

llvm/lib/Transforms/IPO/Attributor.cpp
1769 ↗(On Diff #214717)

intersectAssumedBits is better.

1825 ↗(On Diff #214717)

intersectAssumedBits is better.

1858 ↗(On Diff #214717)

intersectAssumedBits is better.

This revision is now accepted and ready to land.Mon, Aug 12, 9:00 PM
This revision was automatically updated to reflect the committed changes.