This is an archive of the discontinued LLVM Phabricator instance.

Differential D66064

[WebAssembly] Use Register over unsigned in LateEHPrepare (NFC)
ClosedPublic

Authored by aheejin on Aug 11 2019, 1:31 AM.

Details

Reviewers
dsanders
Commits
rG64517a6419ca: Use Register over unsigned in LateEHPrepare (NFC)
rL368727: Use Register over unsigned in LateEHPrepare (NFC)
Summary

While D65962 is pending for review, I landed D65475 that added one more
use of unsigned. Changed it to Register.

Diff Detail

Event Timeline

aheejin created this revision.Aug 11 2019, 1:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2019, 1:31 AM
Herald added subscribers: llvm-commits, hiraditya, jgravelle-google and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B36578: Diff 214554.Aug 11 2019, 1:32 AM
dsanders accepted this revision.Aug 12 2019, 2:15 PM

LGTM

This revision is now accepted and ready to land.Aug 12 2019, 2:15 PM
Closed by commit rL368727: Use Register over unsigned in LateEHPrepare (NFC) (authored by aheejin). · Explain WhyAug 13 2019, 10:34 AM
This revision was automatically updated to reflect the committed changes.
aheejin retitled this revision from Use Register over unsigned in LateEHPrepare (NFC) to [WebAssembly] Use Register over unsigned in LateEHPrepare (NFC).Aug 26 2019, 1:42 AM
Herald added a subscriber: sunfish. · View Herald TranscriptAug 26 2019, 1:42 AM

Revision Contents

PathSize
llvm/
lib/
Target/
WebAssembly/
2 lines

Diff 214554

llvm/lib/Target/WebAssembly/WebAssemblyLateEHPrepare.cpp

Show First 20 Lines • Show All 334 Lines • ▼ Show 20 Lines for (auto *Extract : ExtractInstrs) {
// call @__clang_call_terminate(%exn) // call @__clang_call_terminate(%exn)
// unreachable // unreachable
if (TerminatePads.count(EHPad)) { if (TerminatePads.count(EHPad)) {
Function *ClangCallTerminateFn = Function *ClangCallTerminateFn =
MF.getFunction().getParent()->getFunction( MF.getFunction().getParent()->getFunction(
WebAssembly::ClangCallTerminateFn); WebAssembly::ClangCallTerminateFn);
assert(ClangCallTerminateFn && assert(ClangCallTerminateFn &&
"There is no __clang_call_terminate() function"); "There is no __clang_call_terminate() function");
unsigned Reg = MRI.createVirtualRegister(&WebAssembly::I32RegClass); Register Reg = MRI.createVirtualRegister(&WebAssembly::I32RegClass);
BuildMI(ElseMBB, DL, TII.get(WebAssembly::CONST_I32), Reg).addImm(0); BuildMI(ElseMBB, DL, TII.get(WebAssembly::CONST_I32), Reg).addImm(0);
BuildMI(ElseMBB, DL, TII.get(WebAssembly::CALL_VOID)) BuildMI(ElseMBB, DL, TII.get(WebAssembly::CALL_VOID))
.addGlobalAddress(ClangCallTerminateFn) .addGlobalAddress(ClangCallTerminateFn)
.addReg(Reg); .addReg(Reg);
BuildMI(ElseMBB, DL, TII.get(WebAssembly::UNREACHABLE)); BuildMI(ElseMBB, DL, TII.get(WebAssembly::UNREACHABLE));
} else { } else {
BuildMI(ElseMBB, DL, TII.get(WebAssembly::RETHROW)).addReg(ExnReg); BuildMI(ElseMBB, DL, TII.get(WebAssembly::RETHROW)).addReg(ExnReg);
Show All 39 Lines