Page MenuHomePhabricator

[TextAPI] Fix & Add tests for tbd files version 3.

Authored by cishida on Aug 9 2019, 5:55 PM.


  • There was a simple typo in TextStub code that prevented version 3 files to be read.
  • Included a version 3 unit test to handle the differences in the format.
  • Also a typo in Error.h inside the comments.

Event Timeline

cishida created this revision.Aug 9 2019, 5:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2019, 5:55 PM
ributzka accepted this revision.Aug 12 2019, 9:08 AM

Hi Cyndy, thanks for catching this copy-past-o bug. LGTM


I think this test should work now on windows,

This revision is now accepted and ready to land.Aug 12 2019, 9:08 AM
cishida added inline comments.Aug 12 2019, 9:22 AM

Would removing that macro from all the text stub tests and running them be enough to verify it works on windows?

cishida updated this revision to Diff 214721.Aug 12 2019, 3:20 PM
  • [TextAPI] Remove windows guard from tests
cishida marked an inline comment as done.Aug 12 2019, 3:26 PM

I currently don't have commit access rights to push this patch. Can you commit this change for me while I request access?


resolved with r357759

ributzka closed this revision.Aug 12 2019, 4:01 PM