Page MenuHomePhabricator

[TextAPI] Fix & Add tests for tbd files version 3.
ClosedPublic

Authored by cishida on Fri, Aug 9, 5:55 PM.

Details

Summary
  • There was a simple typo in TextStub code that prevented version 3 files to be read.
  • Included a version 3 unit test to handle the differences in the format.
  • Also a typo in Error.h inside the comments.

Event Timeline

cishida created this revision.Fri, Aug 9, 5:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Aug 9, 5:55 PM
ributzka accepted this revision.Mon, Aug 12, 9:08 AM

Hi Cyndy, thanks for catching this copy-past-o bug. LGTM

llvm/unittests/TextAPI/TextStubV3Tests.cpp
134

I think this test should work now on windows,

This revision is now accepted and ready to land.Mon, Aug 12, 9:08 AM
cishida added inline comments.Mon, Aug 12, 9:22 AM
llvm/unittests/TextAPI/TextStubV3Tests.cpp
134

Would removing that macro from all the text stub tests and running them be enough to verify it works on windows?

cishida updated this revision to Diff 214721.Mon, Aug 12, 3:20 PM
  • [TextAPI] Remove windows guard from tests
cishida marked an inline comment as done.Mon, Aug 12, 3:26 PM

I currently don't have commit access rights to push this patch. Can you commit this change for me while I request access?

llvm/unittests/TextAPI/TextStubV3Tests.cpp
134

resolved with r357759

ributzka closed this revision.Mon, Aug 12, 4:01 PM