Page MenuHomePhabricator

[llvm-readobj] - Remove `error(llvm::Expected<T> &&E)`
ClosedPublic

Authored by grimar on Aug 9 2019, 3:27 AM.

Details

Summary

This is a bit strange method. It works like a unwrapOrError,
but named error. It does not report an Input name.
I removed it.

Rebased on top of D65946

Diff Detail

Event Timeline

grimar created this revision.Aug 9 2019, 3:27 AM
This revision is now accepted and ready to land.Aug 9 2019, 3:31 AM
MaskRay accepted this revision.Aug 9 2019, 3:35 AM

Nice revision number!

grimar added a comment.Aug 9 2019, 3:41 AM

Nice revision number!

:)) I tried to catch something like that from time to time last years, but this one is unintentional. Kind of "we get something for free when do not need it anymore".

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2019, 4:02 AM