Page MenuHomePhabricator

Remove xcode-specific Config.h
ClosedPublic

Authored by labath on Aug 7 2019, 5:03 AM.

Details

Summary

Now that the xcode project is removed, we no longer need/use the
hand-maintained Config.h file, as everything is configured through
cmake.

This patch deletes that file and reverts some of the changes from
r300372, which were made to support this use case.

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Aug 7 2019, 5:03 AM
sgraenitz added a comment.EditedAug 7 2019, 5:13 AM

Originally introduced with D31969. LGTM. Maybe we can remove even more? (here or in future commits)

labath added a comment.Aug 7 2019, 5:21 AM

Originally introduced with D31969. LGTM. Maybe we can remove even more? (here or in future commits)

I don't see what more could be removed here. Most of that patch was about setting up the infrastructure to generate the Config.h in the first place (instead of a bunch of hand-maintained files). That is still it use.

sgraenitz accepted this revision.Aug 7 2019, 5:23 AM

Right

This revision is now accepted and ready to land.Aug 7 2019, 5:23 AM
Closed by commit rL368266: Remove xcode-specific Config.h (authored by labath, committed by ). · Explain WhyAug 8 2019, 1:28 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2019, 1:29 AM