[LLVM][Alignment] Fix MSVC warning

[RKSimon]

Summary

https://bugs.llvm.org/show_bug.cgi?id=42911

[RKSimon]

This isn't handling all the cases - its probably better to push at the top of the file (before namespace) and similarly pop at the end of the file

[gchatelet]

In D65859#1629358, @RKSimon wrote:

This isn't handling all the cases - its probably better to push at the top of the file (before namespace) and similarly pop at the end of the file

Thx Simon, I'm OOO right now and traveling next week. Would you have a chance to check that the fix you offer is fixing the Windows build?

[RKSimon]

Disable MSVC divide by zero warnings for the whole of AlignmentTest.cpp

[RKSimon]

Adding some people interested in MSVC builds

[gbedwell]

I've not tested, but it seems reasonable. The only other "#pragma warning" I came across (in the neighbouring llvm/unittests/Support/AlignOfTest.cpp) doesn't bother with a push/pop and just disables the warnings at file scope. I'm not sure if there's any reason to push/pop across the entire file unless we think we might want to ever include this cpp file inside another one?

[RKSimon]

I'm happy to remove the push/pull if reviewers prefer - its just a personal style preference tbh

[rnk]

lgtm

I prefer push/pop generally.

[gbedwell]

In D65859#1631409, @RKSimon wrote:

I'm happy to remove the push/pull if reviewers prefer - its just a personal style preference tbh

I have no strong preference. LGTM either way.

[gchatelet]

LGTM.
Thx for fixing it!

llvm/unittests/Support/AlignmentTest.cpp

 
 TEST(AlignmentDeathTest, CantConvertUnsetMaybe) {
   EXPECT_DEATH((MaybeAlign(0).getValue()), ".*");
 }
 
 TEST(AlignmentDeathTest, Division) {
   EXPECT_DEATH(Align(1) / 2, "Can't halve byte alignment");
   EXPECT_DEATH(MaybeAlign(1) / 2, "Can't halve byte alignment");
+  EXPECT_DEATH(Align(8) / 3, "Divisor must be positive and a power of 2");
+}
 
+TEST(AlignmentDeathTest, DivisionbyZero) {
+#ifdef _MSC_VER
+// Disable warnings about potential divide by 0.
+#pragma warning(push)
+#pragma warning(disable : 4723)
+#endif
   EXPECT_DEATH(Align(8) / 0, "Divisor must be positive and a power of 2");
-  EXPECT_DEATH(Align(8) / 3, "Divisor must be positive and a power of 2");
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
 }
 
 TEST(AlignmentDeathTest, InvalidCTors) {
   EXPECT_DEATH((Align(0)), "Value must not be 0");
   for (uint64_t Value : getNonPowerOfTwo()) {
     EXPECT_DEATH((Align(Value)), "Alignment is not a power of 2");
     EXPECT_DEATH((MaybeAlign(Value)),
                  "Alignment is neither 0 nor a power of 2");