Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
This isn't handling all the cases - its probably better to push at the top of the file (before namespace) and similarly pop at the end of the file
Thx Simon, I'm OOO right now and traveling next week. Would you have a chance to check that the fix you offer is fixing the Windows build?
I've not tested, but it seems reasonable. The only other "#pragma warning" I came across (in the neighbouring llvm/unittests/Support/AlignOfTest.cpp) doesn't bother with a push/pop and just disables the warnings at file scope. I'm not sure if there's any reason to push/pop across the entire file unless we think we might want to ever include this cpp file inside another one?
I'm happy to remove the push/pull if reviewers prefer - its just a personal style preference tbh