This is an archive of the discontinued LLVM Phabricator instance.

TLI: Darwin sometimes does not support _bcmp, so do not emit it for Darwin
ClosedPublic

Authored by arphaman on Aug 6 2019, 4:29 PM.

Details

Summary

Not all Darwin targets support _bcmp in all circumstances. Unfortunately after https://reviews.llvm.org/D56593 clang started emitting _bcmp for all Darwin targets. This patch reverts the previous behavior for Darwin.

Diff Detail

Repository
rL LLVM

Event Timeline

arphaman created this revision.Aug 6 2019, 4:29 PM
jfb accepted this revision.Aug 6 2019, 4:44 PM

I think importantly, even if Darwin has it it seems to be defined something like this:
https://github.com/apple/darwin-libplatform/blob/51ce256579c9b879704c868c9cd906ae54f733b5/src/string/generic/memcmp.c#L58

This revision is now accepted and ready to land.Aug 6 2019, 4:44 PM
This revision was automatically updated to reflect the committed changes.