This is an archive of the discontinued LLVM Phabricator instance.

[Tooling] Expose ExecutorConcurrency option.
ClosedPublic

Authored by DiegoAstiazaran on Aug 6 2019, 4:09 PM.

Details

Summary

D65628 requires a flag to specify the number of threads for a clang-doc step. It would be good to use ExecutorConcurrency after exposing it instead of creating a new one that has the same purpose.

Diff Detail

Event Timeline

DiegoAstiazaran created this revision.Aug 6 2019, 4:09 PM
DiegoAstiazaran edited the summary of this revision. (Show Details)Aug 7 2019, 12:25 AM
sammccall accepted this revision.Aug 7 2019, 12:51 AM

Only hesitation is that AllTUsExecution is one executor of (potentially) many, so this is a weird place for a common flag.

However it's already "global" in the sense that --help will show it, so we may as well reuse it.
Maybe it should be moved to another file at some point.

This revision is now accepted and ready to land.Aug 7 2019, 12:51 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2019, 11:34 AM