Page MenuHomePhabricator

DiegoAstiazaran (Diego Astiazarán)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2019, 4:03 PM (87 w, 5 d)

Recent Activity

Aug 21 2019

DiegoAstiazaran accepted D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error.

LGTM

Aug 21 2019, 4:35 PM · Restricted Project, Restricted Project

Aug 16 2019

DiegoAstiazaran committed rGee6700f69766: [clang-doc] Fix casting not working in gcc 5.4.0 (authored by DiegoAstiazaran).
[clang-doc] Fix casting not working in gcc 5.4.0
Aug 16 2019, 6:46 PM
DiegoAstiazaran committed rL369182: [clang-doc] Fix casting not working in gcc 5.4.0.
[clang-doc] Fix casting not working in gcc 5.4.0
Aug 16 2019, 6:46 PM
DiegoAstiazaran closed D66378: [clang-doc] Fix casting not working in gcc 5.4.0.
Aug 16 2019, 6:45 PM · Restricted Project, Restricted Project
DiegoAstiazaran created D66378: [clang-doc] Fix casting not working in gcc 5.4.0.
Aug 16 2019, 6:45 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rG3550da79ecdb: [clang-doc] Redesign of generated HTML files (authored by DiegoAstiazaran).
[clang-doc] Redesign of generated HTML files
Aug 16 2019, 11:40 AM
DiegoAstiazaran committed rL369139: [clang-doc] Redesign of generated HTML files.
[clang-doc] Redesign of generated HTML files
Aug 16 2019, 11:40 AM
DiegoAstiazaran closed D66353: [clang-doc] Redesign of generated HTML files.
Aug 16 2019, 11:40 AM · Restricted Project, Restricted Project
DiegoAstiazaran updated the summary of D66353: [clang-doc] Redesign of generated HTML files.
Aug 16 2019, 11:23 AM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D66353: [clang-doc] Redesign of generated HTML files.

Add comments.
Fix clang-doc version.

Aug 16 2019, 11:19 AM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D66353: [clang-doc] Redesign of generated HTML files.

Run clang-format

Aug 16 2019, 9:35 AM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D66353: [clang-doc] Redesign of generated HTML files.

Update clang-doc documentation.

Aug 16 2019, 9:26 AM · Restricted Project, Restricted Project
DiegoAstiazaran added reviewers for D66353: [clang-doc] Redesign of generated HTML files: juliehockett, jakehehrlich.
Aug 16 2019, 9:26 AM · Restricted Project, Restricted Project
DiegoAstiazaran created D66353: [clang-doc] Redesign of generated HTML files.
Aug 16 2019, 9:26 AM · Restricted Project, Restricted Project
DiegoAstiazaran committed rGb46131e5c3ae: [clang-doc] Fix records in global namespace (authored by DiegoAstiazaran).
[clang-doc] Fix records in global namespace
Aug 16 2019, 9:12 AM
DiegoAstiazaran committed rL369123: [clang-doc] Fix records in global namespace.
[clang-doc] Fix records in global namespace
Aug 16 2019, 9:12 AM
DiegoAstiazaran closed D66298: [clang-doc] Fix records in global namespace.
Aug 16 2019, 9:11 AM · Restricted Project, Restricted Project

Aug 15 2019

DiegoAstiazaran updated the diff for D66298: [clang-doc] Fix records in global namespace.

Fix tests that were going to fail in Windows.
Fix tests broken after rebasing.

Aug 15 2019, 9:01 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rGba3d595f93a4: [clang-doc] Serialize inherited attributes and methods (authored by DiegoAstiazaran).
[clang-doc] Serialize inherited attributes and methods
Aug 15 2019, 5:11 PM
DiegoAstiazaran committed rL369075: [clang-doc] Serialize inherited attributes and methods.
[clang-doc] Serialize inherited attributes and methods
Aug 15 2019, 5:09 PM
DiegoAstiazaran closed D66238: [clang-doc] Serialize inherited attributes and methods.
Aug 15 2019, 5:09 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D66238: [clang-doc] Serialize inherited attributes and methods.

Rebase to master

Aug 15 2019, 4:45 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rGb7bb9fb28f09: [clang-doc] Sort index elements case insensitive (authored by DiegoAstiazaran).
[clang-doc] Sort index elements case insensitive
Aug 15 2019, 4:32 PM
DiegoAstiazaran committed rL369068: [clang-doc] Sort index elements case insensitive.
[clang-doc] Sort index elements case insensitive
Aug 15 2019, 4:31 PM
DiegoAstiazaran closed D66299: [clang-doc] Sort index elements case insensitive.
Aug 15 2019, 4:31 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rG77dc05b945ad: [clang-doc] Fix use of source-root flag (authored by DiegoAstiazaran).
[clang-doc] Fix use of source-root flag
Aug 15 2019, 4:21 PM
DiegoAstiazaran committed rL369065: [clang-doc] Fix use of source-root flag.
[clang-doc] Fix use of source-root flag
Aug 15 2019, 4:20 PM
DiegoAstiazaran closed D66268: [clang-doc] Fix use of source-root flag.
Aug 15 2019, 4:19 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rG6a29ae4bde96: [clang-doc] Fix bitcode writer for access specifiers (authored by DiegoAstiazaran).
[clang-doc] Fix bitcode writer for access specifiers
Aug 15 2019, 4:06 PM
DiegoAstiazaran committed rL369063: [clang-doc] Fix bitcode writer for access specifiers.
[clang-doc] Fix bitcode writer for access specifiers
Aug 15 2019, 4:03 PM
DiegoAstiazaran closed D66151: [clang-doc] Fix bitcode writer.
Aug 15 2019, 4:03 PM · Restricted Project, Restricted Project
DiegoAstiazaran created D66299: [clang-doc] Sort index elements case insensitive.
Aug 15 2019, 8:23 AM · Restricted Project, Restricted Project
DiegoAstiazaran created D66298: [clang-doc] Fix records in global namespace.
Aug 15 2019, 8:22 AM · Restricted Project, Restricted Project

Aug 14 2019

DiegoAstiazaran added inline comments to D66238: [clang-doc] Serialize inherited attributes and methods.
Aug 14 2019, 7:09 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D66238: [clang-doc] Serialize inherited attributes and methods.

Increase version number of clang-doc bitcode.
Rename documentInfo function to shouldSerializeInfo.
In new parseBases a BaseRecordInfo object is created and then added to Bases of main RecordInfo.
Fix comments.

Aug 14 2019, 7:07 PM · Restricted Project, Restricted Project
DiegoAstiazaran created D66268: [clang-doc] Fix use of source-root flag.
Aug 14 2019, 6:28 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rG6169a730886b: [clang-doc] Add missing check in tests (authored by DiegoAstiazaran).
[clang-doc] Add missing check in tests
Aug 14 2019, 1:22 PM
DiegoAstiazaran committed rL368912: [clang-doc] Add missing check in tests.
[clang-doc] Add missing check in tests
Aug 14 2019, 1:19 PM
DiegoAstiazaran closed D66124: [clang-doc] Add missing check in tests.
Aug 14 2019, 1:18 PM · Restricted Project, Restricted Project
DiegoAstiazaran created D66238: [clang-doc] Serialize inherited attributes and methods.
Aug 14 2019, 12:25 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D66151: [clang-doc] Fix bitcode writer.

Use getAccess() instead of getAccessUnsafe() for CXXMethodDecl.
Add comments in YAML generator to specify that AS_none is used as the default here because it's the AS that shouldn't be part of the output. Even though AS_public is the default in the struct, it should be displayed in the YAML output.

Aug 14 2019, 12:08 PM · Restricted Project, Restricted Project

Aug 13 2019

DiegoAstiazaran updated the diff for D66151: [clang-doc] Fix bitcode writer.

Default value of AccessSpecifier attributes is now AS_public.
Multiple tests modified.

Aug 13 2019, 2:38 PM · Restricted Project, Restricted Project
DiegoAstiazaran created D66151: [clang-doc] Fix bitcode writer.
Aug 13 2019, 10:26 AM · Restricted Project, Restricted Project

Aug 12 2019

DiegoAstiazaran created D66124: [clang-doc] Add missing check in tests.
Aug 12 2019, 6:43 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rGe27f778a1992: [clang-doc] Generate HTML links for children namespaces/records (authored by DiegoAstiazaran).
[clang-doc] Generate HTML links for children namespaces/records
Aug 12 2019, 11:44 AM
DiegoAstiazaran committed rL368602: [clang-doc] Generate HTML links for children namespaces/records.
[clang-doc] Generate HTML links for children namespaces/records
Aug 12 2019, 11:42 AM
DiegoAstiazaran closed D65987: [clang-doc] Generate HTML links for children namespaces/records.
Aug 12 2019, 11:42 AM · Restricted Project, Restricted Project

Aug 9 2019

DiegoAstiazaran committed rGdc30049cb360: [clang-doc] Generate an HTML index file (authored by DiegoAstiazaran).
[clang-doc] Generate an HTML index file
Aug 9 2019, 1:54 PM
DiegoAstiazaran committed rL368484: [clang-doc] Generate an HTML index file.
[clang-doc] Generate an HTML index file
Aug 9 2019, 1:54 PM
DiegoAstiazaran closed D65918: [clang-doc] Generate an HTML index file.
Aug 9 2019, 1:54 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65987: [clang-doc] Generate HTML links for children namespaces/records.

Change the implementation of computeRelativePath

Aug 9 2019, 1:50 PM · Restricted Project, Restricted Project
DiegoAstiazaran added inline comments to D65987: [clang-doc] Generate HTML links for children namespaces/records.
Aug 9 2019, 11:52 AM · Restricted Project, Restricted Project
DiegoAstiazaran added inline comments to D65987: [clang-doc] Generate HTML links for children namespaces/records.
Aug 9 2019, 11:18 AM · Restricted Project, Restricted Project
DiegoAstiazaran committed rG665e9676c257: [clang-format] Add link to source code in file definitions (authored by DiegoAstiazaran).
[clang-format] Add link to source code in file definitions
Aug 9 2019, 10:50 AM
DiegoAstiazaran committed rL368460: [clang-format] Add link to source code in file definitions.
[clang-format] Add link to source code in file definitions
Aug 9 2019, 10:50 AM
DiegoAstiazaran closed D65483: [clang-doc] Add link to source code in file definitions.
Aug 9 2019, 10:49 AM · Restricted Project, Restricted Project

Aug 8 2019

DiegoAstiazaran created D65987: [clang-doc] Generate HTML links for children namespaces/records.
Aug 8 2019, 5:45 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rGe2d4577075f6: [clang-doc] Protect Index with mutex during reducing and generation stage (authored by DiegoAstiazaran).
[clang-doc] Protect Index with mutex during reducing and generation stage
Aug 8 2019, 10:14 AM
DiegoAstiazaran committed rL368313: [clang-doc] Protect Index with mutex during reducing and generation stage.
[clang-doc] Protect Index with mutex during reducing and generation stage
Aug 8 2019, 10:13 AM
DiegoAstiazaran closed D65915: [clang-doc] Protect Index with mutex during reducing and generation stage.
Aug 8 2019, 10:13 AM · Restricted Project, Restricted Project

Aug 7 2019

DiegoAstiazaran created D65918: [clang-doc] Generate an HTML index file.
Aug 7 2019, 6:34 PM · Restricted Project, Restricted Project
DiegoAstiazaran added a reviewer for D65915: [clang-doc] Protect Index with mutex during reducing and generation stage: jakehehrlich.
Aug 7 2019, 6:13 PM · Restricted Project, Restricted Project
DiegoAstiazaran created D65915: [clang-doc] Protect Index with mutex during reducing and generation stage.
Aug 7 2019, 6:11 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65483: [clang-doc] Add link to source code in file definitions.

Rebase to master

Aug 7 2019, 2:33 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65483: [clang-doc] Add link to source code in file definitions.

Add comments.
Move definition of ClangDocContext constructor to .cpp file.

Aug 7 2019, 2:24 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rGd47be4da5ab2: [clang-doc] Add second index for sections within info's content (authored by DiegoAstiazaran).
[clang-doc] Add second index for sections within info's content
Aug 7 2019, 2:06 PM
DiegoAstiazaran committed rL368209: [clang-doc] Add second index for sections within info's content.
[clang-doc] Add second index for sections within info's content
Aug 7 2019, 2:05 PM
DiegoAstiazaran closed D65030: [clang-doc] Add second index for sections within info's content.
Aug 7 2019, 2:05 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65030: [clang-doc] Add second index for sections within info's content.
Aug 7 2019, 2:05 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rG6ab28e8cbae1: [clang-doc] Parallelize reducing phase (authored by DiegoAstiazaran).
[clang-doc] Parallelize reducing phase
Aug 7 2019, 1:55 PM
DiegoAstiazaran committed rL368206: [clang-doc] Parallelize reducing phase.
[clang-doc] Parallelize reducing phase
Aug 7 2019, 1:54 PM
DiegoAstiazaran closed D65628: [clang-doc] Parallelize reducing phase.
Aug 7 2019, 1:54 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65628: [clang-doc] Parallelize reducing phase.

Add comment

Aug 7 2019, 1:46 PM · Restricted Project, Restricted Project
DiegoAstiazaran added inline comments to D65628: [clang-doc] Parallelize reducing phase.
Aug 7 2019, 12:38 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65628: [clang-doc] Parallelize reducing phase.

Use pre-existing concurrency flag --execute-concurrency instead implementing a new one.

Aug 7 2019, 12:38 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rGba55970c150b: [Tooling] Expose ExecutorConcurrency option. (authored by DiegoAstiazaran).
[Tooling] Expose ExecutorConcurrency option.
Aug 7 2019, 11:37 AM
DiegoAstiazaran committed rL368196: [Tooling] Expose ExecutorConcurrency option..
[Tooling] Expose ExecutorConcurrency option.
Aug 7 2019, 11:34 AM
DiegoAstiazaran closed D65833: [Tooling] Expose ExecutorConcurrency option..
Aug 7 2019, 11:34 AM · Restricted Project
DiegoAstiazaran updated the summary of D65833: [Tooling] Expose ExecutorConcurrency option..
Aug 7 2019, 12:29 AM · Restricted Project

Aug 6 2019

DiegoAstiazaran updated the diff for D65483: [clang-doc] Add link to source code in file definitions.

Remove unnecessary type casting.

Aug 6 2019, 6:27 PM · Restricted Project, Restricted Project
DiegoAstiazaran added inline comments to D65483: [clang-doc] Add link to source code in file definitions.
Aug 6 2019, 6:17 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65483: [clang-doc] Add link to source code in file definitions.

Add comments.
Change name of flag; root-directory -> --source-root
Moved fixing of repository link to ClangDocContext constructor and add test where the prefix is omitted.
RepositoryLink in ClangDocContext struct and writeFileDefinition function is now llvm::Optional<>

Aug 6 2019, 6:17 PM · Restricted Project, Restricted Project
DiegoAstiazaran created D65833: [Tooling] Expose ExecutorConcurrency option..
Aug 6 2019, 4:09 PM · Restricted Project
DiegoAstiazaran committed rG40fde9019327: [clang-doc] Fix paths of js in import tags (authored by DiegoAstiazaran).
[clang-doc] Fix paths of js in import tags
Aug 6 2019, 2:00 PM
DiegoAstiazaran committed rL368087: [clang-doc] Fix paths of js in import tags.
[clang-doc] Fix paths of js in import tags
Aug 6 2019, 2:00 PM
DiegoAstiazaran closed D65827: [clang-doc] Fix paths of js in import tags.
Aug 6 2019, 2:00 PM · Restricted Project, Restricted Project
DiegoAstiazaran created D65827: [clang-doc] Fix paths of js in import tags.
Aug 6 2019, 1:57 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65030: [clang-doc] Add second index for sections within info's content.

Changed JumpToSection in Index struct and genHTML(const Index &Index, ...) function to llvm::Optional<StringRef>.

Aug 6 2019, 1:48 PM · Restricted Project, Restricted Project
DiegoAstiazaran committed rG7dfe0bc3c162: [clang-doc] Add index in each info html file (authored by DiegoAstiazaran).
[clang-doc] Add index in each info html file
Aug 6 2019, 11:32 AM
DiegoAstiazaran committed rL368070: [clang-doc] Add index in each info html file.
[clang-doc] Add index in each info html file
Aug 6 2019, 11:32 AM
DiegoAstiazaran closed D65690: [clang-doc] Add index in each info html file.
Aug 6 2019, 11:32 AM · Restricted Project, Restricted Project

Aug 5 2019

DiegoAstiazaran added inline comments to D65030: [clang-doc] Add second index for sections within info's content.
Aug 5 2019, 7:51 PM · Restricted Project, Restricted Project
DiegoAstiazaran added inline comments to D65690: [clang-doc] Add index in each info html file.
Aug 5 2019, 7:51 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65690: [clang-doc] Add index in each info html file.

Moved serialization of Index to HTML generator.

Aug 5 2019, 6:45 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D65030: [clang-doc] Add second index for sections within info's content.

Changed dependency of commit, D65003 was abandoned and replaced by D65690.
Rebased to latest commit so HTML is now rendered correctly.
genHTML(const Index &Index, ...) was originally implemented by D65003 but it is now part of this commit.

Aug 5 2019, 6:30 PM · Restricted Project, Restricted Project
DiegoAstiazaran abandoned D65003: [clang-doc] Add index in each info html file.

D65690 replaces this revision.

Aug 5 2019, 6:12 PM · Restricted Project
DiegoAstiazaran committed rG15e468e0d5b7: [clang-doc] Fix link generation (authored by DiegoAstiazaran).
[clang-doc] Fix link generation
Aug 5 2019, 5:12 PM
DiegoAstiazaran committed rL367958: [clang-doc] Fix link generation.
[clang-doc] Fix link generation
Aug 5 2019, 5:10 PM
DiegoAstiazaran closed D64958: [clang-doc] Fix link generation.
Aug 5 2019, 5:10 PM · Restricted Project, Restricted Project
DiegoAstiazaran updated the diff for D64958: [clang-doc] Fix link generation.

Fix comments.

Aug 5 2019, 5:08 PM · Restricted Project, Restricted Project