Page MenuHomePhabricator

Detect HAVE_SYS_TYPES_H in lldb
ClosedPublic

Authored by hhb on Aug 6 2019, 12:20 PM.

Details

Summary

After rL368069 I noticed that HAVE_SYS_TYPES_H is not defined in
Platform.h, or anywhere else in lldb. This change fixes that.

Diff Detail

Repository
rL LLVM

Event Timeline

hhb created this revision.Aug 6 2019, 12:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 12:20 PM
hhb updated this revision to Diff 213687.Aug 6 2019, 12:21 PM

Remove a test code.

hhb updated this revision to Diff 213688.Aug 6 2019, 12:23 PM

Remove test code

hhb added a comment.Aug 6 2019, 12:24 PM

I'm not really know how this works before, given no one includes Config.h. Or maybe sys/types.h is never needed?

Harbormaster completed remote builds in B36257: Diff 213688.
hhb updated this revision to Diff 213689.Aug 6 2019, 12:29 PM

Add one more place

srhines added inline comments.
lldb/include/lldb/Host/windows/PosixApi.h
56 ↗(On Diff #213689)

Update comment.

hhb updated this revision to Diff 213726.Aug 6 2019, 2:44 PM

Fix comment.

hhb marked an inline comment as done.Aug 6 2019, 2:44 PM
labath accepted this revision.Aug 6 2019, 11:08 PM

Woops, this is quite embarrassing. :/

One day we should audit these to check which of these files really needs to include this header, but since there are at least some files that definitely need it, adding the cmake check is the right way to go...

This revision is now accepted and ready to land.Aug 6 2019, 11:08 PM
Closed by commit rL368125: Detect HAVE_SYS_TYPES_H in lldb (authored by hhb, committed by ). · Explain WhyAug 6 2019, 11:15 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 11:15 PM