This is an archive of the discontinued LLVM Phabricator instance.

Add order-dependencies to object libraries
ClosedPublic

Authored by beanz on Aug 6 2019, 10:16 AM.

Details

Summary

If you are generating an object library that depends on table-gen generate sources, you need the object library to depend on the tablgen target. Currently llvm_add_library doesn't add dependencies for object libraries at all, which is clearly problematic.

Event Timeline

beanz created this revision.Aug 6 2019, 10:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 10:16 AM
Herald added a subscriber: mgorny. · View Herald Transcript
smeenai accepted this revision.Aug 6 2019, 10:57 AM

LGTM

This revision is now accepted and ready to land.Aug 6 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.