[ELF] Fix splitting messages for duplicate symbols.

[ikudrin]

Summary

D65213 does not work for the case when a source file path includes subdirectories.

[MaskRay]

test/ELF/vs-diagnostics-duplicate-split.s

2 ↗

(On Diff #213622)

Delete Inputs/vs-diagnostics-duplicate-split.s

llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
not ld.lld --vs-diagnostics --shared %t.o %t.o -o /dev/null 2>&1

...
>>>{{.*}}.o:(.text+0x{{.+}})

[ikudrin]

• Removed Inputs/vs-diagnostics-duplicate-split.s
• Updated the test accordingly.

[ruiu]

LGTM

lld/trunk/Common/ErrorHandler.cpp

void ErrorHandler::warn(const Twine &msg) {
   sep = getSeparator(msg);
 }
 
 void ErrorHandler::error(const Twine &msg) {
   // If Visual Studio-style error message mode is enabled,
   // this particular error is printed out as two errors.
   if (vsDiagnostics) {
     static std::regex re(R"(^(duplicate symbol: .*))"
-                         R"((\n>>> defined at \S+:\d+\n>>>.*))"
-                         R"((\n>>> defined at \S+:\d+\n>>>.*))");
+                         R"((\n>>> defined at \S+:\d+.*\n>>>.*))"
+                         R"((\n>>> defined at \S+:\d+.*\n>>>.*))");
     std::string str = msg.str();
     std::smatch m;
 
     if (std::regex_match(str, m, re)) {
       error(m.str(1) + m.str(2));
       error(m.str(1) + m.str(3));
       return;
     }

lld/trunk/test/ELF/vs-diagnostics-duplicate-split.s

+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
+// RUN: not ld.lld --vs-diagnostics --shared %t.o %t.o -o /dev/null 2>&1 | FileCheck %s
+
+// CHECK:      duplicate.s(15): error: duplicate symbol: foo
+// CHECK-NEXT: >>> defined at duplicate.s:15 (/tmp/duplicate.s:15)
+// CHECK-NEXT: >>>{{.*}}.o:(.text+0x{{.+}})
+// CHECK:      duplicate.s(15): error: duplicate symbol: foo
+// CHECK-NEXT: >>> defined at duplicate.s:15 (/tmp/duplicate.s:15)
+// CHECK-NEXT: >>>{{.*}}.o:(.text+0x{{.+}})
+
+.file 1 "/tmp" "duplicate.s"
+
+.global foo
+.text
+.loc 1 15
+foo:
+  nop
+
+.section .debug_abbrev,"",@progbits
+  .byte  1                      # Abbreviation Code
+  .byte 17                      # DW_TAG_compile_unit
+  .byte  0                      # DW_CHILDREN_no
+  .byte 16                      # DW_AT_stmt_list
+  .byte 23                      # DW_FORM_sec_offset
+  .byte  0                      # EOM(1)
+  .byte  0                      # EOM(2)
+  .byte  0                      # EOM(3)
+
+.section .debug_info,"",@progbits
+  .long .Lend0 - .Lbegin0       # Length of Unit
+.Lbegin0:
+  .short 4                      # DWARF version number
+  .long  .debug_abbrev          # Offset Into Abbrev. Section
+  .byte  8                      # Address Size (in bytes)
+  .byte  1                      # Abbrev [1] 0xb:0x1f DW_TAG_compile_unit
+  .long  .debug_line            # DW_AT_stmt_list
+.Lend0:
+  .section .debug_line,"",@progbits