Page MenuHomePhabricator

[ELF] Fix splitting messages for duplicate symbols.
ClosedPublic

Authored by ikudrin on Aug 6 2019, 8:35 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ikudrin created this revision.Aug 6 2019, 8:35 AM
Herald added a project: Restricted Project. · View Herald Transcript
MaskRay added inline comments.Aug 6 2019, 9:52 PM
test/ELF/vs-diagnostics-duplicate-split.s
2 ↗(On Diff #213622)

Delete Inputs/vs-diagnostics-duplicate-split.s

llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
not ld.lld --vs-diagnostics --shared %t.o %t.o -o /dev/null 2>&1

...
>>>{{.*}}.o:(.text+0x{{.+}})
ikudrin updated this revision to Diff 213802.Aug 6 2019, 11:56 PM
  • Removed Inputs/vs-diagnostics-duplicate-split.s
  • Updated the test accordingly.
ruiu accepted this revision.Aug 7 2019, 2:12 AM

LGTM

This revision is now accepted and ready to land.Aug 7 2019, 2:12 AM
MaskRay accepted this revision.Aug 7 2019, 3:09 AM
This revision was automatically updated to reflect the committed changes.