Page MenuHomePhabricator

Add support for FreeBSD's LD_32_LIBRARY_PATH
ClosedPublic

Authored by dim on Aug 5 2019, 1:16 PM.

Details

Summary

Because the dynamic linker for 32-bit executables on 64-bit FreeBSD uses
the environment variable LD_32_LIBRARY_PATH instead of
LD_LIBRARY_PATH to find needed dynamic libraries, running the 32-bit
parts of the dynamic ASan tests will fail with errors similar to:

ld-elf32.so.1: Shared object "libclang_rt.asan-i386.so" not found, required by "Asan-i386-inline-Dynamic-Test"

This adds support for setting up LD_32_LIBRARY_PATH for the unit and
regression tests. It will likely also require a minor change to the
TestingConfig class in llvm/utils/lit/lit.

Diff Detail

Repository
rL LLVM

Event Timeline

dim created this revision.Aug 5 2019, 1:16 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 5 2019, 1:16 PM
Herald added subscribers: Restricted Project, delcypher, fedor.sergeev and 2 others. · View Herald Transcript
arichardson accepted this revision.Aug 9 2019, 9:05 AM

LGTM. This reduces the check-asan-dynamic test failures from 209 to 50 if I also apply the -pthread patch.

This revision is now accepted and ready to land.Aug 9 2019, 9:05 AM
This revision was automatically updated to reflect the committed changes.