This is an archive of the discontinued LLVM Phabricator instance.

[LLVM][Alignment] Introduce Alignment In CallingConv
ClosedPublic

Authored by gchatelet on Aug 2 2019, 7:57 AM.

Details

Summary

This is patch is part of a serie to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Event Timeline

gchatelet created this revision.Aug 2 2019, 7:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 2 2019, 7:57 AM
gchatelet marked 2 inline comments as done.Aug 2 2019, 8:30 AM
gchatelet added inline comments.
llvm/include/llvm/CodeGen/CallingConvLower.h
425

When most of the callers are switched to using the new Align type we can flip the interface, for now it triggers too many code changes.

llvm/include/llvm/CodeGen/TargetCallingConv.h
124

We do not change the interface just yet as it would trigger too many changes.
Here we introduce the type in the implementation only.
This helps making sure that setters are always using defined alignments (i.e. >=1)

jfb accepted this revision.Aug 2 2019, 9:53 AM
This revision is now accepted and ready to land.Aug 2 2019, 9:53 AM
This revision was automatically updated to reflect the committed changes.