Page MenuHomePhabricator

[lit] use built-in clear_environment instead of external env command
AbandonedPublic

Authored by inglorion on Aug 1 2019, 4:30 PM.

Details

Summary

r366980 made lit invocations instead invoke env ...options... lit. This
invokes the external env command, which we generally avoid (as per
r242696). This change replaces the env invocation by lit's built-in
clear_environment configuration functionality.

Event Timeline

inglorion created this revision.Aug 1 2019, 4:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2019, 4:30 PM
Herald added a subscriber: delcypher. · View Herald Transcript
rnk added a comment.Aug 1 2019, 4:36 PM

I think this ended up being reverted in rL367627, see the discussion on the review:
https://reviews.llvm.org/D65156#1610296

I suppose you can abandon this and @jdenny can use this solution or come up with a different one.

inglorion abandoned this revision.Aug 1 2019, 4:40 PM

Heh, I just missed the revert. @jdenny, feel free to use this as inspiration.

jdenny added a comment.Aug 1 2019, 4:51 PM

Heh, I just missed the revert. @jdenny, feel free to use this as inspiration.

Thanks. :-)

I believe that also clears those variables for the outer lit running lit's test suite. I only wanted to clear them for the %{lit} calls within lit's test suite.