This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Do not allocate unnecessary emergency slot.
ClosedPublic

Authored by sdesmalen on Jul 31 2019, 2:36 AM.

Details

Summary

Fix an issue where the compiler still allocates an emergency spill slot even
though it already decided to spill an extra callee-save register to use
as a scratch register.

Diff Detail

Repository
rL LLVM

Event Timeline

sdesmalen created this revision.Jul 31 2019, 2:36 AM
thegameg accepted this revision.Jul 31 2019, 10:59 AM

This LGTM, thanks!

test/CodeGen/AArch64/extra-callee-save.mir
7 ↗(On Diff #212542)

You should be able to get rid of the IR completely here.

This revision is now accepted and ready to land.Jul 31 2019, 10:59 AM
sdesmalen marked an inline comment as done.Aug 1 2019, 3:53 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2019, 3:54 AM