Page MenuHomePhabricator

[llvm-lipo] Implement -segalign
ClosedPublic

Authored by anushabasana on Jul 29 2019, 2:20 PM.

Details

Summary

Sets section alignments of the specified architecture slices to the alignment values.
Alignment values are hexadecimal values that are powers of 2.

Test Plan: check-llvm

Diff Detail

Repository
rL LLVM

Event Timeline

anushabasana created this revision.Jul 29 2019, 2:20 PM
alexshap added inline comments.Jul 29 2019, 3:46 PM
llvm/test/tools/llvm-lipo/segalign.test
5 ↗(On Diff #212227)

I'd add a run of llvm-lipo with exactly the same input but without -segalign to make it easier to see the difference.
Also I'd add a comment regarding the format of -segalign (in particular, it expects a hex)

Added test without segalign for comparison

anushabasana marked an inline comment as done.Jul 30 2019, 12:01 PM
alexshap accepted this revision.Jul 30 2019, 2:38 PM
This revision is now accepted and ready to land.Jul 30 2019, 2:38 PM
This revision was automatically updated to reflect the committed changes.