This is an archive of the discontinued LLVM Phabricator instance.

[dotest] Remove multiprocessing
ClosedPublic

Authored by JDevlieghere on Jul 25 2019, 5:39 PM.

Details

Summary

Now that the Xcode project is removed, I want to focus on dotest as a test framework, and remove its driver capabilities for which we can rely on lit. Removing multiprocessing is the first step in that direction.

Diff Detail

Repository
rL LLVM

Event Timeline

JDevlieghere created this revision.Jul 25 2019, 5:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2019, 5:39 PM

Remove more options and external references.

This seems okay to me. I would also check with Jason. I don't know who coordinates running tests remotely - or even if they can run in parallel now. But that's the one bit I don't understand well enough to say yea or nay on.

I'm not sure it's really relevant when lit is the driver, but I would often use --no-multiprocess with dotest to see the full trace output of a single test while it was running. In multiprocess mode that wasn't displayed iirc. That's my only use of it. I do use --threads 1 when doing a testsuite run against a device because there's some buggy behavior in the lldb testsuite when running multiple tests simultaneously on a remote device (at least a remote darwin device). But I'm sure you're not talking about removing that control.

JDevlieghere added a comment.EditedJul 29 2019, 2:24 PM

I'm not sure it's really relevant when lit is the driver, but I would often use --no-multiprocess with dotest to see the full trace output of a single test while it was running. In multiprocess mode that wasn't displayed iirc. That's my only use of it. I do use --threads 1 when doing a testsuite run against a device because there's some buggy behavior in the lldb testsuite when running multiple tests simultaneously on a remote device (at least a remote darwin device). But I'm sure you're not talking about removing that control.

Yup, at this point I'm just removing multiprocessing support. However, the ultimate goal is to have no driving capabilities in dotest at all, which would mean it can only run a single test at a time. You'd still be able to achieve a single thread by passing to lit (the driver) with -j1.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 30 2019, 9:46 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 30 2019, 9:46 AM
lldb/trunk/packages/Python/lldbsuite/test/configuration.py