This is an archive of the discontinued LLVM Phabricator instance.

[clang][docs][release notes] mention asm goto support
ClosedPublic

Authored by nickdesaulniers on Jul 25 2019, 3:42 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2019, 3:42 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nickdesaulniers marked an inline comment as done.Jul 25 2019, 3:43 PM
nickdesaulniers added inline comments.
clang/docs/ReleaseNotes.rst
116 ↗(On Diff #211843)

I wasn't sure the best way to state something along the lines of "support is in beta shape, plz report bugz?"

hans added a comment.Jul 26 2019, 10:20 AM

Thanks!

Do you want to write something more general for the release notes about the status of Clang and the Linux kernel?

clang/docs/ReleaseNotes.rst
116 ↗(On Diff #211843)

How about starting with "Initial support has been added for ...", and ending with "There are still unsupported corner cases in Clang's integrated assembler and in IfConverter. Please file bugs for any issues you run into." ?

  • add details about ClangBuiltLinux
nickdesaulniers marked an inline comment as done.Jul 26 2019, 1:57 PM

Thanks for the tips, how does that look @hans ?

hans accepted this revision.Jul 26 2019, 2:23 PM

Looks great!

Go ahead and commit directly to the branch (I think it can only be done with SVN still), or let me know if you'd like me to do it.

clang/docs/ReleaseNotes.rst
255 ↗(On Diff #212002)

nit: I'd prefer "Clang 9" without the hyphen.

257 ↗(On Diff #212002)

Clang 4

This revision is now accepted and ready to land.Jul 26 2019, 2:23 PM

Go ahead and commit directly to the branch (I think it can only be done with SVN still), or let me know if you'd like me to do it.

Thanks again for the review and tips. I was going to ask how does committing work now...

I don't have an SVN checkout; would you be so kind as to please merge this on my behalf?

hans added a comment.Jul 26 2019, 2:30 PM

I don't have an SVN checkout; would you be so kind as to please merge this on my behalf?

Committed in r367158.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2019, 2:34 PM