This is an archive of the discontinued LLVM Phabricator instance.

Differential D65217

[MIPS GlobalISel] Select inttoptr and ptrtoint
ClosedPublic

Authored by Petar.Avramovic on Jul 24 2019, 8:41 AM.

Details

Reviewers
atanasyan
petarj
Commits
rGb1fc6f613016: [MIPS GlobalISel] Select inttoptr and ptrtoint
rL367104: [MIPS GlobalISel] Select inttoptr and ptrtoint
Summary

Select G_INTTOPTR and G_PTRTOINT for MIPS32.

Diff Detail

Event Timeline

Petar.Avramovic created this revision.Jul 24 2019, 8:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2019, 8:41 AM
Herald added subscribers: llvm-commits, jrtc27, arichardson and 2 others. · View Herald Transcript
atanasyan accepted this revision.Jul 26 2019, 5:01 AM

LGTM

This revision is now accepted and ready to land.Jul 26 2019, 5:01 AM
Closed by commit rL367104: [MIPS GlobalISel] Select inttoptr and ptrtoint (authored by Petar.Avramovic). · Explain WhyJul 26 2019, 6:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
Mips/
5 lines
5 lines
2 lines
test/
CodeGen/
Mips/
GlobalISel/
instruction-select/
51 lines
legalizer/
48 lines
llvm-ir/
24 lines
regbankselect/
50 lines

Diff 211519

lib/Target/Mips/MipsInstructionSelector.cpp

Show First 20 Lines • Show All 259 Lines • ▼ Show 20 Linesbool MipsInstructionSelector::select(MachineInstr &I,
} }
case G_GEP: { case G_GEP: {
MI = BuildMI(MBB, I, I.getDebugLoc(), TII.get(Mips::ADDu)) MI = BuildMI(MBB, I, I.getDebugLoc(), TII.get(Mips::ADDu))
.add(I.getOperand(0)) .add(I.getOperand(0))
.add(I.getOperand(1)) .add(I.getOperand(1))
.add(I.getOperand(2)); .add(I.getOperand(2));
break; break;
} }
case G_INTTOPTR:
case G_PTRTOINT: {
I.setDesc(TII.get(COPY));
return selectCopy(I, MRI);
}
case G_FRAME_INDEX: { case G_FRAME_INDEX: {
MI = BuildMI(MBB, I, I.getDebugLoc(), TII.get(Mips::ADDiu)) MI = BuildMI(MBB, I, I.getDebugLoc(), TII.get(Mips::ADDiu))
.add(I.getOperand(0)) .add(I.getOperand(0))
.add(I.getOperand(1)) .add(I.getOperand(1))
.addImm(0); .addImm(0);
break; break;
} }
case G_BRCOND: { case G_BRCOND: {
▲ Show 20 Lines • Show All 396 Lines • Show Last 20 Lines

lib/Target/Mips/MipsLegalizerInfo.cpp

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines getActionDefinitionsBuilder(G_ICMP)
.legalForCartesianProduct({s32}, {s32, p0}) .legalForCartesianProduct({s32}, {s32, p0})
.clampScalar(1, s32, s32) .clampScalar(1, s32, s32)
.minScalar(0, s32); .minScalar(0, s32);
getActionDefinitionsBuilder(G_CONSTANT) getActionDefinitionsBuilder(G_CONSTANT)
.legalFor({s32}) .legalFor({s32})
.clampScalar(0, s32, s32); .clampScalar(0, s32, s32);
getActionDefinitionsBuilder(G_GEP) getActionDefinitionsBuilder({G_GEP, G_INTTOPTR})
.legalFor({{p0, s32}}); .legalFor({{p0, s32}});
getActionDefinitionsBuilder(G_PTRTOINT)
.legalFor({{s32, p0}});
getActionDefinitionsBuilder(G_FRAME_INDEX) getActionDefinitionsBuilder(G_FRAME_INDEX)
.legalFor({p0}); .legalFor({p0});
getActionDefinitionsBuilder(G_GLOBAL_VALUE) getActionDefinitionsBuilder(G_GLOBAL_VALUE)
.legalFor({p0}); .legalFor({p0});
// FP instructions // FP instructions
getActionDefinitionsBuilder(G_FCONSTANT) getActionDefinitionsBuilder(G_FCONSTANT)
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines

lib/Target/Mips/MipsRegisterBankInfo.cpp

Show First 20 Lines • Show All 382 Lines • ▼ Show 20 LinesMipsRegisterBankInfo::getInstrMapping(const MachineInstr &MI) const {
case G_TRUNC: case G_TRUNC:
case G_ADD: case G_ADD:
case G_SUB: case G_SUB:
case G_MUL: case G_MUL:
case G_UMULH: case G_UMULH:
case G_ZEXTLOAD: case G_ZEXTLOAD:
case G_SEXTLOAD: case G_SEXTLOAD:
case G_GEP: case G_GEP:
case G_INTTOPTR:
case G_PTRTOINT:
case G_AND: case G_AND:
case G_OR: case G_OR:
case G_XOR: case G_XOR:
case G_SHL: case G_SHL:
case G_ASHR: case G_ASHR:
case G_LSHR: case G_LSHR:
case G_SDIV: case G_SDIV:
case G_UDIV: case G_UDIV:
▲ Show 20 Lines • Show All 279 Lines • Show Last 20 Lines

test/CodeGen/Mips/GlobalISel/instruction-select/inttoptr_and_ptrtoint.mir

  • This file was added.
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -O0 -mtriple=mipsel-linux-gnu -run-pass=instruction-select -verify-machineinstrs %s -o - | FileCheck %s -check-prefixes=MIPS32
--- |
define void @inttoptr() {entry: ret void}
define void @ptrtoint() {entry: ret void}
...
---
name: inttoptr
alignment: 2
legalized: true
regBankSelected: true
tracksRegLiveness: true
body: |
bb.1.entry:
liveins: $a0
; MIPS32-LABEL: name: inttoptr
; MIPS32: liveins: $a0
; MIPS32: [[COPY:%[0-9]+]]:gpr32 = COPY $a0
; MIPS32: $v0 = COPY [[COPY]]
; MIPS32: RetRA implicit $v0
%0:gprb(s32) = COPY $a0
%1:gprb(p0) = G_INTTOPTR %0(s32)
$v0 = COPY %1(p0)
RetRA implicit $v0
...
---
name: ptrtoint
alignment: 2
legalized: true
regBankSelected: true
tracksRegLiveness: true
body: |
bb.1.entry:
liveins: $a0
; MIPS32-LABEL: name: ptrtoint
; MIPS32: liveins: $a0
; MIPS32: [[COPY:%[0-9]+]]:gpr32 = COPY $a0
; MIPS32: $v0 = COPY [[COPY]]
; MIPS32: RetRA implicit $v0
%0:gprb(p0) = COPY $a0
%1:gprb(s32) = G_PTRTOINT %0(p0)
$v0 = COPY %1(s32)
RetRA implicit $v0
...

test/CodeGen/Mips/GlobalISel/legalizer/inttoptr_and_ptrtoint.mir

  • This file was added.
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -O0 -mtriple=mipsel-linux-gnu -run-pass=legalizer -verify-machineinstrs %s -o - | FileCheck %s -check-prefixes=MIPS32
--- |
define void @inttoptr() {entry: ret void}
define void @ptrtoint() {entry: ret void}
...
---
name: inttoptr
alignment: 2
tracksRegLiveness: true
body: |
bb.1.entry:
liveins: $a0
; MIPS32-LABEL: name: inttoptr
; MIPS32: liveins: $a0
; MIPS32: [[COPY:%[0-9]+]]:_(s32) = COPY $a0
; MIPS32: [[INTTOPTR:%[0-9]+]]:_(p0) = G_INTTOPTR [[COPY]](s32)
; MIPS32: $v0 = COPY [[INTTOPTR]](p0)
; MIPS32: RetRA implicit $v0
%0:_(s32) = COPY $a0
%1:_(p0) = G_INTTOPTR %0(s32)
$v0 = COPY %1(p0)
RetRA implicit $v0
...
---
name: ptrtoint
alignment: 2
tracksRegLiveness: true
body: |
bb.1.entry:
liveins: $a0
; MIPS32-LABEL: name: ptrtoint
; MIPS32: liveins: $a0
; MIPS32: [[COPY:%[0-9]+]]:_(p0) = COPY $a0
; MIPS32: [[PTRTOINT:%[0-9]+]]:_(s32) = G_PTRTOINT [[COPY]](p0)
; MIPS32: $v0 = COPY [[PTRTOINT]](s32)
; MIPS32: RetRA implicit $v0
%0:_(p0) = COPY $a0
%1:_(s32) = G_PTRTOINT %0(p0)
$v0 = COPY %1(s32)
RetRA implicit $v0
...

test/CodeGen/Mips/GlobalISel/llvm-ir/inttoptr_and_ptrtoint.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc -O0 -mtriple=mipsel-linux-gnu -global-isel -verify-machineinstrs %s -o -| FileCheck %s -check-prefixes=MIPS32
define i32* @inttoptr(i32 %a) {
; MIPS32-LABEL: inttoptr:
; MIPS32: # %bb.0: # %entry
; MIPS32-NEXT: move $2, $4
; MIPS32-NEXT: jr $ra
; MIPS32-NEXT: nop
entry:
%0 = inttoptr i32 %a to i32*
ret i32* %0
}
define i32 @ptrtoint(i32* %a) {
; MIPS32-LABEL: ptrtoint:
; MIPS32: # %bb.0: # %entry
; MIPS32-NEXT: move $2, $4
; MIPS32-NEXT: jr $ra
; MIPS32-NEXT: nop
entry:
%0 = ptrtoint i32* %a to i32
ret i32 %0
}

test/CodeGen/Mips/GlobalISel/regbankselect/inttoptr_and_ptrtoint.mir

  • This file was added.
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -O0 -mtriple=mipsel-linux-gnu -run-pass=regbankselect -verify-machineinstrs %s -o - | FileCheck %s -check-prefixes=MIPS32
--- |
define void @inttoptr() {entry: ret void}
define void @ptrtoint() {entry: ret void}
...
---
name: inttoptr
alignment: 2
legalized: true
tracksRegLiveness: true
body: |
bb.1.entry:
liveins: $a0
; MIPS32-LABEL: name: inttoptr
; MIPS32: liveins: $a0
; MIPS32: [[COPY:%[0-9]+]]:gprb(s32) = COPY $a0
; MIPS32: [[INTTOPTR:%[0-9]+]]:gprb(p0) = G_INTTOPTR [[COPY]](s32)
; MIPS32: $v0 = COPY [[INTTOPTR]](p0)
; MIPS32: RetRA implicit $v0
%0:_(s32) = COPY $a0
%1:_(p0) = G_INTTOPTR %0(s32)
$v0 = COPY %1(p0)
RetRA implicit $v0
...
---
name: ptrtoint
alignment: 2
legalized: true
tracksRegLiveness: true
body: |
bb.1.entry:
liveins: $a0
; MIPS32-LABEL: name: ptrtoint
; MIPS32: liveins: $a0
; MIPS32: [[COPY:%[0-9]+]]:gprb(p0) = COPY $a0
; MIPS32: [[PTRTOINT:%[0-9]+]]:gprb(s32) = G_PTRTOINT [[COPY]](p0)
; MIPS32: $v0 = COPY [[PTRTOINT]](s32)
; MIPS32: RetRA implicit $v0
%0:_(p0) = COPY $a0
%1:_(s32) = G_PTRTOINT %0(p0)
$v0 = COPY %1(s32)
RetRA implicit $v0
...