This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Provide help text to users who run `clangd` in a terminal.
ClosedPublic

Authored by sammccall on Jul 24 2019, 5:10 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall created this revision.Jul 24 2019, 5:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2019, 5:10 AM
hokein accepted this revision.Jul 24 2019, 5:23 AM
hokein added inline comments.
clang-tools-extra/clangd/tool/ClangdMain.cpp
430 ↗(On Diff #211470)

do we want to exit clangd for this case?

This revision is now accepted and ready to land.Jul 24 2019, 5:23 AM
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2019, 1:00 AM

Oops, forgot to hit send.

clang-tools-extra/clangd/tool/ClangdMain.cpp
430 ↗(On Diff #211470)

I'd prefer not to, it's only "somewhat likely" the user is confused - there's a chance they're going to e.g. paste in LSP messages.

Also behaving *completely* differently when connected to a TTY violates expectations and can make debugging hard. Changing the log output seems fine, refusing to speak the protocol doesn't.

hokein added inline comments.Jul 25 2019, 1:59 AM
clang-tools-extra/clangd/tool/ClangdMain.cpp
430 ↗(On Diff #211470)

Sounds good.