Page MenuHomePhabricator

[clangd] Add categories to help options, and only show clangd options.
ClosedPublic

Authored by sammccall on Jul 24 2019, 4:58 AM.

Details

Summary

Restricting the categories prevents extra unwanted options from creeping into
help (D60663), and removes a bunch of noise from --help-hidden.

While here, remove static from the opts in favor of an anon namespace, to
reduce the noise level.

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall created this revision.Jul 24 2019, 4:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2019, 4:58 AM
hokein accepted this revision.Jul 24 2019, 5:27 AM
hokein added inline comments.
clang-tools-extra/clangd/tool/ClangdMain.cpp
59 ↗(On Diff #211469)

maybe also group these options by the their categories?

This revision is now accepted and ready to land.Jul 24 2019, 5:27 AM
sammccall marked an inline comment as done.Jul 24 2019, 5:37 AM
sammccall added inline comments.
clang-tools-extra/clangd/tool/ClangdMain.cpp
59 ↗(On Diff #211469)

Done, and sorted by name. Bye bye version history, though :-/

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2019, 5:43 AM