Page MenuHomePhabricator

SymbolVendor: Remove the type list member
ClosedPublic

Authored by labath on Jul 23 2019, 3:00 AM.

Details

Summary

Similarly to the compile unit lists, the list of types can also be
managed by the symbol file itself.

Since the only purpose of this list seems to be to maintain an owning
reference to all the types a symbol file has created (items are only
ever added to the list, never retrieved), I remove the passthrough
functions in SymbolVendor and Module. I also tighten the interface of
the function (return a reference instead of a pointer, make it protected
instead of public).

Diff Detail

Repository
rL LLVM

Event Timeline

labath created this revision.Jul 23 2019, 3:00 AM
JDevlieghere accepted this revision.Jul 23 2019, 1:27 PM
JDevlieghere added inline comments.
source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
1286 ↗(On Diff #211268)

nit: maybe we can const this and the one below?

This revision is now accepted and ready to land.Jul 23 2019, 1:27 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2019, 1:23 AM