Page MenuHomePhabricator

AMDGPU: Start redefining atomic PatFrags
ClosedPublic

Authored by arsenm on Jul 22 2019, 6:07 AM.

Details

Summary

Start migrating to a form that will be compatible with the global isel
emitter. Also should fix some overly lax checks on the memory type,
which allowed mis-selecting some illegal atomics.

Diff Detail

Event Timeline

arsenm created this revision.Jul 22 2019, 6:07 AM

I'm not sure I can follow all the consequences of this change, but as for tablegen usage it looks good.

rampitec accepted this revision.Jul 22 2019, 10:45 AM

LGTM, but please add more comment about cmpswap before sumbitting.

lib/Target/AMDGPU/AMDGPUInstructions.td
572

You need to add a little bit more of a comment here.

This revision is now accepted and ready to land.Jul 22 2019, 10:45 AM
arsenm closed this revision.Wed, Jul 31, 8:25 PM
arsenm marked an inline comment as done.

r367506