[ASan][test] XFAIL AddressSanitizer-*-sunos :: TestCases/intercept-rethrow-exception.cc on Solaris

[ro]

Summary

AddressSanitizer-*-sunos :: TestCases/intercept-rethrow-exception.cc currently FAILs
on Solaris. This happens because std::rethrow_exception cannot be intercepted, as
detailed in Bug 42703.

To account for this and reduce testsuite noise, this patch XFAILs the test.

Tested on x86_64-pc-solaris2.11. Ok for trunk?

[ro]

Ping? It's been a week now. Is there some policy not to xfail the test which as documented in the bug cannot pass on Solaris?

[ro]

This comment was removed by ro.

[ro]

This comment was removed by ro.

[vitalybuka]

In D65056#1603902, @ro wrote:

Ping? It's been a week now. Is there some policy not to xfail the test which as documented in the bug cannot pass on Solaris?

If the test fails consistently on the platform and there is a chance to make it pass some day, I would prefer to have XFAIL.

You can try to check activity of reviewers or just extend a list.
@samsonov is currently not active member of LLVM
@kcc was just too busy

[ro]

In D65056#1604957, @vitalybuka wrote:

In D65056#1603902, @ro wrote:

Ping? It's been a week now. Is there some policy not to xfail the test which as documented in the bug cannot pass on Solaris?

If the test fails consistently on the platform and there is a chance to make it pass some day, I would prefer to have XFAIL.

I certainly mean to construct a massivly reduced testcase and check with the Solaris linker engineer if he sees a way to avoid
triggering the recursive call to AsanInitInternal triggered by dlsym. However, right now there are more pressing issues like
2-stage builds failing on both Solaris/SPARC and x86.

You can try to check activity of reviewers or just extend a list.
@samsonov is currently not active member of LLVM

I'd started with the listed maintainers initially.

@kcc was just too busy

I see. I've tried to extend the reviewer list beyond the maintainers, but found it somewhat difficult to determine appropriate
candidates in areas that see not too much activity. Probably need to broaden where I look...

compiler-rt/trunk/test/asan/TestCases/intercept-rethrow-exception.cc

 // Regression test for
 // https://bugs.llvm.org/show_bug.cgi?id=32434
 
 // RUN: %clangxx_asan -fexceptions -O0 %s -o %t
 // RUN: %run %t
 
 // The current implementation of this functionality requires special
 // combination of libraries that are not used by default on NetBSD
 // XFAIL: netbsd
+// FIXME: Bug 42703
+// XFAIL: solaris
 
 #include <assert.h>
 #include <exception>
 #include <sanitizer/asan_interface.h>
 
 namespace {
 
 // Not instrumented because std::rethrow_exception is a [[noreturn]] function,