Page MenuHomePhabricator

[CMake] Align debugserver with lldb-server on Darwin
ClosedPublic

Authored by sgraenitz on Jul 19 2019, 7:28 AM.

Details

Summary

Make debugserver a tool like lldb-server, so it can be included/excluded via LLDB_TOOL_DEBUGSERVER_BUILD. This replaces the old LLDB_NO_DEBUGSERVER flag. Doing the same for darwin-debug while I am here.

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Jul 19 2019, 7:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 19 2019, 7:29 AM
Herald added a subscriber: mgorny. · View Herald Transcript
sgraenitz marked an inline comment as done.Jul 19 2019, 8:04 AM
sgraenitz added inline comments.
lldb/test/CMakeLists.txt
113 ↗(On Diff #210832)

Not sure if this needs test suite support.

JDevlieghere accepted this revision.Jul 19 2019, 8:26 AM
This revision is now accepted and ready to land.Jul 19 2019, 8:26 AM
xiaobai accepted this revision.Jul 19 2019, 10:55 AM

Excellent, thanks for taking care of this! :)

Closed by commit rL366631: [CMake] Align debugserver with lldb-server on Darwin (authored by stefan.graenitz, committed by ). · Explain WhyJul 20 2019, 4:18 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2019, 4:18 AM