This is an archive of the discontinued LLVM Phabricator instance.

[Tsan] Fix the atomic_race.cc test to pass on systems with high loads
ClosedPublic

Authored by kutuzov.viktor.84 on Dec 2 2014, 6:25 AM.

Details

Summary

The current delay duration is too short for the FreeBSD buildbot slave:

http://lab.llvm.org:8011/buildslaves/as-bldslv5

that serves several FreeBSD buildbots:

http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd
http://lab.llvm.org:8011/builders/lld-x86_64-freebsd
http://lab.llvm.org:8011/builders/clang-mergefunc-x86_64-freebsd

and runs the lit tests in 64 threads (which is what lit.py does by default on this machine). Due to this insufficient delay the output for the reverse tests come before the output for the ordinary ones. It seems with four-second delay we pass this test persistently.

Diff Detail

Repository
rL LLVM

Event Timeline

kutuzov.viktor.84 retitled this revision from to [Tsan] Fix the atomic_race.cc test to pass on systems with high loads.
kutuzov.viktor.84 updated this object.
kutuzov.viktor.84 edited the test plan for this revision. (Show Details)
kutuzov.viktor.84 added subscribers: Unknown Object (MLST), emaste.
dvyukov accepted this revision.Dec 2 2014, 6:38 AM
dvyukov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 2 2014, 6:38 AM
Diffusion closed this revision.Dec 2 2014, 7:05 AM
Diffusion updated this revision to Diff 16810.

Closed by commit rL223122 (authored by vkutuzov).