This is an archive of the discontinued LLVM Phabricator instance.

Differential D64704

[WebAssembly] Simplify regcopy.mir
ClosedPublic

Authored by aheejin on Jul 14 2019, 3:13 AM.

Details

Reviewers
tlively
Commits
rG474009eaea76: [WebAssembly] Simplify regcopy.mir
rL366140: [WebAssembly] Simplify regcopy.mir
Summary

This deletes the ll templates from the functions because they don't need
them (mir files need ll templates only when they have function calls or
BB names that are not numbers).

This also renames the filename to reg-copy.mir, because I'm planning
to add some more reg-*.mir soon.

Diff Detail

Repository
rL LLVM

Event Timeline

aheejin created this revision.Jul 14 2019, 3:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2019, 3:13 AM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google and 2 others. · View Herald Transcript
Harbormaster completed remote builds in B34966: Diff 209716.Jul 14 2019, 3:17 AM
aheejin updated this revision to Diff 209717.Jul 14 2019, 3:31 AM

reg_instr.mir -> reg-instr.mir

aheejin edited the summary of this revision. (Show Details)Jul 14 2019, 3:31 AM
Harbormaster completed remote builds in B34967: Diff 209717.Jul 14 2019, 3:33 AM
aheejin updated this revision to Diff 209718.Jul 14 2019, 4:02 AM

Cancel renaming

aheejin edited the summary of this revision. (Show Details)Jul 14 2019, 4:02 AM
Harbormaster completed remote builds in B34968: Diff 209718.Jul 14 2019, 4:03 AM
aheejin updated this revision to Diff 209719.Jul 14 2019, 4:04 AM

regcopy.mir -> reg-copy.mir

aheejin edited the summary of this revision. (Show Details)Jul 14 2019, 4:05 AM
Harbormaster completed remote builds in B34969: Diff 209719.Jul 14 2019, 4:05 AM
aheejin added a child revision: D64705: [WebAssembly] Add missing utility methods for exnref type.Jul 14 2019, 4:34 AM
tlively accepted this revision.Jul 15 2019, 2:05 PM
This revision is now accepted and ready to land.Jul 15 2019, 2:05 PM
Closed by commit rL366140: [WebAssembly] Simplify regcopy.mir (authored by aheejin). · Explain WhyJul 15 2019, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
CodeGen/
WebAssembly/
57 lines
80 lines

Diff 209971

llvm/trunk/test/CodeGen/WebAssembly/reg-copy.mir

# RUN: llc -mtriple=wasm32-unknown-unknown %s -o - -run-pass=postrapseudos | FileCheck %s
---
name: copy_i32
# CHECK-LABEL: copy_i32
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:i32 = COPY_I32 %1:i32
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:i32 = COPY %1:i32
RETURN_VOID implicit-def $arguments
...
---
name: copy_i64
# CHECK-LABEL: copy_i64
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:i64 = COPY_I64 %1:i64
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:i64 = COPY %1:i64
RETURN_VOID implicit-def $arguments
...
---
name: copy_f32
# CHECK-LABEL: copy_f32
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:f32 = COPY_F32 %1:f32
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:f32 = COPY %1:f32
RETURN_VOID implicit-def $arguments
...
---
name: copy_f64
# CHECK-LABEL: copy_f64
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:f64 = COPY_F64 %1:f64
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:f64 = COPY %1:f64
RETURN_VOID implicit-def $arguments
...
---
name: copy_v128
# CHECK-LABEL: copy_v128
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:v128 = COPY_V128 %1:v128
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:v128 = COPY %1:v128
RETURN_VOID implicit-def $arguments
...

llvm/trunk/test/CodeGen/WebAssembly/regcopy.mir

# RUN: llc %s -o - -run-pass=postrapseudos | FileCheck %s
--- |
target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
target triple = "wasm32-unknown-unknown"
define void @copy_i32() {
ret void
}
define void @copy_i64() {
ret void
}
define void @copy_f32() {
ret void
}
define void @copy_f64() {
ret void
}
define void @copy_v128() {
ret void
}
...
---
name: copy_i32
# CHECK-LABEL: copy_i32
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:i32 = COPY_I32 %1:i32
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:i32 = COPY %1:i32
RETURN_VOID implicit-def $arguments
...
---
name: copy_i64
# CHECK-LABEL: copy_i64
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:i64 = COPY_I64 %1:i64
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:i64 = COPY %1:i64
RETURN_VOID implicit-def $arguments
...
---
name: copy_f32
# CHECK-LABEL: copy_f32
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:f32 = COPY_F32 %1:f32
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:f32 = COPY %1:f32
RETURN_VOID implicit-def $arguments
...
---
name: copy_f64
# CHECK-LABEL: copy_f64
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:f64 = COPY_F64 %1:f64
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:f64 = COPY %1:f64
RETURN_VOID implicit-def $arguments
...
---
name: copy_v128
# CHECK-LABEL: copy_v128
body: |
; CHECK-LABEL: bb.0:
; CHECK-NEXT: %0:v128 = COPY_V128 %1:v128
; CHECK-NEXT: RETURN_VOID
bb.0:
%0:v128 = COPY %1:v128
RETURN_VOID implicit-def $arguments
...
llvm/trunk/test/CodeGen/WebAssembly/reg-copy.mir