This is an archive of the discontinued LLVM Phabricator instance.

[GitSVN][NFC] Mark dry-run commits as such in the log output
ClosedPublic

Authored by jdoerfert on Jul 13 2019, 9:58 AM.

Reviewers

Commits

Summary

This helps to avoid worries about the "dry run flag" while testing.

xbolva00 added inline comments.

llvm/utils/git-svn/git-llvm
604 ↗	(On Diff #209702)	Why?

LGTM (after you remove the typo)

This revision is now accepted and ready to land.Jul 13 2019, 11:15 AM

jdoerfert marked an inline comment as done.Jul 14 2019, 11:23 AM

jdoerfert added inline comments.

llvm/utils/git-svn/git-llvm
604 ↗	(On Diff #209702)	Random bit-flip ;) Not intentional.

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

utils/

git-svn/

4 lines

Show First 20 Lines • Show All 414 Lines • ▼ Show 20 Lines	if dot_git_dir == '--git-common-dir':
dot_git_dir = git('rev-parse', '--git-dir')		dot_git_dir = git('rev-parse', '--git-dir')

svn_root = os.path.join(dot_git_dir, 'llvm-upstream-svn')		svn_root = os.path.join(dot_git_dir, 'llvm-upstream-svn')
svn_init(svn_root)		svn_init(svn_root)

rev_range = args.rev_range		rev_range = args.rev_range
dry_run = args.dry_run		dry_run = args.dry_run
revs = get_revs_to_push(rev_range)		revs = get_revs_to_push(rev_range)
log('Pushing %d %s commit%s:\n%s' %		log('%sPushing %d %s commit%s:\n%s' %
(len(revs),		('[DryRun] ' if dry_run else '', len(revs),
'split-repo (%s)' % split_repo_path		'split-repo (%s)' % split_repo_path
if split_repo_path else 'monorepo',		if split_repo_path else 'monorepo',
's' if len(revs) != 1 else '',		's' if len(revs) != 1 else '',
'\n'.join(' ' + git('show', '--oneline', '--quiet', c)		'\n'.join(' ' + git('show', '--oneline', '--quiet', c)
for c in revs)))		for c in revs)))
for r in revs:		for r in revs:
clean_svn(svn_root)		clean_svn(svn_root)
svn_push_one_rev(svn_root, r, git_to_svn_mapping, dry_run)		svn_push_one_rev(svn_root, r, git_to_svn_mapping, dry_run)
▲ Show 20 Lines • Show All 189 Lines • Show Last 20 Lines