This is an archive of the discontinued LLVM Phabricator instance.

Fix heapapi.h dependency in

Authored by mcgov on Jul 12 2019, 9:04 PM.



Removing heapapi.h include to get rid of mingw32 dependency issues.

Diff Detail

Event Timeline

mcgov created this revision.Jul 12 2019, 9:04 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 12 2019, 9:04 PM
mcgov updated this revision to Diff 209678.Jul 12 2019, 9:21 PM

remove commented out work on GlobalAlloc :)

Thanks for the quick action, this is almost perfect! In my env I had to add an explicit stddef.h include (which didn't cause trouble with use of free) in order to get a typedef of size_t.

mcgov updated this revision to Diff 209904.Jul 15 2019, 10:38 AM

scrooched the includes up to fix the typedef issue with size_t

rnk accepted this revision.Jul 15 2019, 10:52 AM

Looks good to me too. :)

This revision is now accepted and ready to land.Jul 15 2019, 10:52 AM
mcgov closed this revision.Jul 15 2019, 11:42 AM

closing, submitted as commit 08204d2610b095fbddea6959ea6a2fc8a4543ada

Thanks! Seems to build fine for me now.