Page MenuHomePhabricator

mcgov (Matthew G McGovern)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2018, 10:21 AM (139 w, 4 d)

Recent Activity

Nov 30 2020

mcgov accepted D92344: [WinASan] Improve exception reporting accuracy.
Nov 30 2020, 3:29 PM · Restricted Project
mcgov added a comment to D92344: [WinASan] Improve exception reporting accuracy.

lgtm

Nov 30 2020, 3:29 PM · Restricted Project

Sep 24 2020

mcgov added inline comments to D87105: [sanitizers][Windows] Better debug output and continuable option for interception failures on Windows.
Sep 24 2020, 9:07 AM · Restricted Project

Sep 15 2020

mcgov requested review of D87715: [sanitizers][windows] Clang-Format asan_malloc_win.
Sep 15 2020, 12:28 PM

Sep 4 2020

mcgov added inline comments to D87105: [sanitizers][Windows] Better debug output and continuable option for interception failures on Windows.
Sep 4 2020, 10:48 AM · Restricted Project

Sep 3 2020

mcgov updated the diff for D87105: [sanitizers][Windows] Better debug output and continuable option for interception failures on Windows.

removed whitespace diff

Sep 3 2020, 11:59 AM · Restricted Project
mcgov updated the diff for D87105: [sanitizers][Windows] Better debug output and continuable option for interception failures on Windows.

fixed, break should occur if the env variable is not set OR if there was an error finding the variable, so anytime the return code is 0.

Sep 3 2020, 11:55 AM · Restricted Project
mcgov planned changes to D87105: [sanitizers][Windows] Better debug output and continuable option for interception failures on Windows.
Sep 3 2020, 11:44 AM · Restricted Project
mcgov requested review of D87105: [sanitizers][Windows] Better debug output and continuable option for interception failures on Windows.
Sep 3 2020, 11:43 AM · Restricted Project

Jan 8 2020

mcgov abandoned D72011: [sanitizers][windows] Global/LocalAlloc interception and tests.
Jan 8 2020, 9:33 AM · Restricted Project, Restricted Project

Dec 30 2019

mcgov updated the diff for D72011: [sanitizers][windows] Global/LocalAlloc interception and tests.

rebased to master

Dec 30 2019, 4:58 PM · Restricted Project, Restricted Project
mcgov planned changes to D72011: [sanitizers][windows] Global/LocalAlloc interception and tests.

Planning to rebase this patch on master instead of release/9.x

Dec 30 2019, 12:51 PM · Restricted Project, Restricted Project
mcgov updated the summary of D72011: [sanitizers][windows] Global/LocalAlloc interception and tests.
Dec 30 2019, 12:51 PM · Restricted Project, Restricted Project
mcgov updated the diff for D72011: [sanitizers][windows] Global/LocalAlloc interception and tests.

clang formatted the patch

Dec 30 2019, 12:45 PM · Restricted Project, Restricted Project
mcgov updated the summary of D72011: [sanitizers][windows] Global/LocalAlloc interception and tests.
Dec 30 2019, 12:33 PM · Restricted Project, Restricted Project
mcgov created D72011: [sanitizers][windows] Global/LocalAlloc interception and tests.
Dec 30 2019, 12:27 PM · Restricted Project, Restricted Project

Aug 29 2019

mcgov committed rG11802ccc9ff9: [cmake] enable x86 libfuzzer on Windows (authored by mcgov).
[cmake] enable x86 libfuzzer on Windows
Aug 29 2019, 10:49 AM
mcgov committed rL370390: [cmake] enable x86 libfuzzer on Windows.
[cmake] enable x86 libfuzzer on Windows
Aug 29 2019, 10:48 AM
mcgov closed D66899: [cmake][sanititzers] enable libfuzzer build on win32.

Committed revision 370390.
Committed abac219120d to svn.
git: https://github.com/llvm/llvm-project/commit/11802ccc9ff9348828128202ce91c549cc84a446

Aug 29 2019, 10:48 AM · Restricted Project, Restricted Project

Aug 28 2019

mcgov created D66899: [cmake][sanititzers] enable libfuzzer build on win32.
Aug 28 2019, 11:09 AM · Restricted Project, Restricted Project

Aug 22 2019

mcgov committed rG2eaeba6f15d3: LibFuzzer support for 32bit MSVC (authored by mcgov).
LibFuzzer support for 32bit MSVC
Aug 22 2019, 1:51 PM
mcgov committed rL369704: LibFuzzer support for 32bit MSVC.
LibFuzzer support for 32bit MSVC
Aug 22 2019, 1:43 PM

Aug 12 2019

mcgov added a comment to rL368598: [builtins] MSVC warning disable for clean build.

Fixed editor! Thank you for the tip :)

Aug 12 2019, 1:04 PM
mcgov committed rG38a1aa117f3d: [builtins] MSVC warning disable for clean build - https://reviews.llvm. (authored by mcgov).
[builtins] MSVC warning disable for clean build - https://reviews.llvm.
Aug 12 2019, 11:09 AM
mcgov committed rL368598: [builtins] MSVC warning disable for clean build.
[builtins] MSVC warning disable for clean build
Aug 12 2019, 11:09 AM

Aug 9 2019

mcgov added inline comments to D66023: Warning disable for mod-by-zero and union 'uninitialized' use.
Aug 9 2019, 1:45 PM · Restricted Project, Restricted Project
mcgov committed rG8e2842cc859b: [sanitizers] MSVC warning disable for clean build - https://reviews.llvm. (authored by mcgov).
[sanitizers] MSVC warning disable for clean build - https://reviews.llvm.
Aug 9 2019, 1:10 PM
mcgov committed rL368476: [sanitizers] MSVC warning disable for clean build.
[sanitizers] MSVC warning disable for clean build
Aug 9 2019, 1:09 PM
mcgov closed D66023: Warning disable for mod-by-zero and union 'uninitialized' use.
Aug 9 2019, 1:00 PM · Restricted Project, Restricted Project
mcgov updated the diff for D66023: Warning disable for mod-by-zero and union 'uninitialized' use.
Aug 9 2019, 1:00 PM · Restricted Project, Restricted Project
mcgov updated the diff for D66023: Warning disable for mod-by-zero and union 'uninitialized' use.

update to add !defined(clang)

Aug 9 2019, 12:57 PM · Restricted Project, Restricted Project
mcgov created D66023: Warning disable for mod-by-zero and union 'uninitialized' use.
Aug 9 2019, 12:30 PM · Restricted Project, Restricted Project

Jul 15 2019

mcgov committed rG4885978e2316: [sanitizers][windows][mingw32] Mingw32 RTL fixes RTL interception broke mingw32… (authored by mcgov).
[sanitizers][windows][mingw32] Mingw32 RTL fixes RTL interception broke mingw32…
Jul 15 2019, 11:44 AM
mcgov committed rL366105: [sanitizers][windows][mingw32] Mingw32 RTL fixes.
[sanitizers][windows][mingw32] Mingw32 RTL fixes
Jul 15 2019, 11:43 AM
mcgov closed D64694: Fix heapapi.h dependency in asan_malloc_win.cc.

closing, submitted as commit 08204d2610b095fbddea6959ea6a2fc8a4543ada

Jul 15 2019, 11:43 AM · Restricted Project, Restricted Project
mcgov updated the diff for D64694: Fix heapapi.h dependency in asan_malloc_win.cc.

scrooched the includes up to fix the typedef issue with size_t

Jul 15 2019, 10:39 AM · Restricted Project, Restricted Project

Jul 12 2019

mcgov updated the diff for D64694: Fix heapapi.h dependency in asan_malloc_win.cc.

remove commented out work on GlobalAlloc :)

Jul 12 2019, 9:25 PM · Restricted Project, Restricted Project
mcgov created D64694: Fix heapapi.h dependency in asan_malloc_win.cc.
Jul 12 2019, 9:04 PM · Restricted Project, Restricted Project
mcgov closed D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

@mrstojo no worries! I'm very new and still learning how to be a good contributor so I appreciate feedback on what I'm doing wrong. I will remove the heapapi include and replace with just the function prototypes I needed along with those constants.

Jul 12 2019, 9:03 PM · Restricted Project, Restricted Project

Jul 8 2019

mcgov committed rG4e636156ef2e: [sanitizers][windows] FIX: Rtl-Heap Interception and tests (authored by mcgov).
[sanitizers][windows] FIX: Rtl-Heap Interception and tests
Jul 8 2019, 6:56 PM
mcgov committed rL365424: [sanitizers][windows] FIX: Rtl-Heap Interception and tests.
[sanitizers][windows] FIX: Rtl-Heap Interception and tests
Jul 8 2019, 6:55 PM
mcgov committed rG848a19e4eb66: [sanitizers][windows] Rtl-Heap Interception and tests - Adds interceptors… (authored by mcgov).
[sanitizers][windows] Rtl-Heap Interception and tests - Adds interceptors…
Jul 8 2019, 6:51 PM
mcgov committed rL365422: [sanitizers][windows] Rtl-Heap Interception and tests.
[sanitizers][windows] Rtl-Heap Interception and tests
Jul 8 2019, 6:47 PM
mcgov committed rGc9fa99d066f0: [sanitizers][windows] Rtl-Heap Interception and tests - Adds interceptors… (authored by mcgov).
[sanitizers][windows] Rtl-Heap Interception and tests - Adds interceptors…
Jul 8 2019, 1:04 PM
mcgov committed rL365381: [sanitizers][windows] Rtl-Heap Interception and tests.
[sanitizers][windows] Rtl-Heap Interception and tests
Jul 8 2019, 12:58 PM

Jul 3 2019

mcgov updated the diff for D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

Updating for RNK comments

Jul 3 2019, 2:11 PM · Restricted Project, Restricted Project
mcgov added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

Just pinging again for review to land this if possible.

Jul 3 2019, 10:00 AM · Restricted Project, Restricted Project

Jun 28 2019

mcgov added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

updated consexpr and namespace issue

Jun 28 2019, 3:56 PM · Restricted Project, Restricted Project

Jun 25 2019

mcgov added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

Addressing comments

Jun 25 2019, 11:28 AM · Restricted Project, Restricted Project
mcgov updated the diff for D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

addressing comments from @vitalybuka
changing macros to constexpr
moving private stuff into asan namespace

Jun 25 2019, 11:25 AM · Restricted Project, Restricted Project

Jun 24 2019

mcgov added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

Another bump for review from @rnk or @vitalybuka

Jun 24 2019, 12:38 PM · Restricted Project, Restricted Project

Jun 21 2019

mcgov added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

@vitalybuka Heya, not marking as done but need some feedback from you.

Jun 21 2019, 10:51 AM · Restricted Project, Restricted Project

Jun 20 2019

mcgov added inline comments to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.
Jun 20 2019, 1:47 PM · Restricted Project, Restricted Project
mcgov added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

addressing comments from @vitalybuka

Jun 20 2019, 1:20 PM · Restricted Project, Restricted Project
mcgov updated the diff for D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

Code cleaning, adding comments for clarity

Jun 20 2019, 1:14 PM · Restricted Project, Restricted Project
mcgov added inline comments to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.
Jun 20 2019, 11:48 AM · Restricted Project, Restricted Project
mcgov updated the diff for D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

Switches CMake config and environment variable to turn tests on to an ASAN_OPTIONS runtime variable. This makes the activation and testing cleaner, as well as the code itself.

Jun 20 2019, 9:03 AM · Restricted Project, Restricted Project
mcgov added a comment to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

@rnk @vitalybuka @mstorsjo ready for review :)

Jun 20 2019, 9:03 AM · Restricted Project, Restricted Project

Jun 19 2019

mcgov planned changes to D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

Modifying to make this option selectable at runtime. This makes it cleaner, without needing config and env var hacks

Jun 19 2019, 2:12 PM · Restricted Project, Restricted Project

Jun 10 2019

mcgov updated the diff for D62927: [sanitizers][windows] Rtl-Heap Interception and tests.
Jun 10 2019, 9:25 AM · Restricted Project, Restricted Project

Jun 6 2019

mcgov updated the diff for D62927: [sanitizers][windows] Rtl-Heap Interception and tests.

updating to mask RTL interception from x64 (not supported yet)

Jun 6 2019, 1:53 PM · Restricted Project, Restricted Project

Jun 5 2019

mcgov updated the diff for D62927: [sanitizers][windows] Rtl-Heap Interception and tests.
Jun 5 2019, 12:37 PM · Restricted Project, Restricted Project
mcgov created D62927: [sanitizers][windows] Rtl-Heap Interception and tests.
Jun 5 2019, 12:37 PM · Restricted Project, Restricted Project

Apr 29 2019

mcgov committed rGd62416dfcd3b: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in… (authored by mcgov).
[AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in…
Apr 29 2019, 1:29 PM
mcgov committed rL359498: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in….
[AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in…
Apr 29 2019, 1:29 PM
mcgov committed rCRT359498: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in….
[AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in…
Apr 29 2019, 1:29 PM
mcgov closed D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.

closed with revision 359498

Apr 29 2019, 1:28 PM · Restricted Project, Restricted Project
mcgov updated the diff for D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.

fix BYTE typdef and incorrect format

Apr 29 2019, 1:05 PM · Restricted Project, Restricted Project
mcgov added a comment to D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.

Ready for review (clang-format only applied to new code)

Apr 29 2019, 12:48 PM · Restricted Project, Restricted Project
mcgov updated the diff for D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.

fix call to get_usable_size so that it is not called unless HEAP_ZERO_MEMORY is passed in (the only case when it is needed).

Apr 29 2019, 12:47 PM · Restricted Project, Restricted Project
mcgov updated the diff for D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.

Update diff to only apply clang-format to new code

Apr 29 2019, 12:46 PM · Restricted Project, Restricted Project
mcgov planned changes to D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.
Apr 29 2019, 11:09 AM · Restricted Project, Restricted Project
mcgov added a comment to D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.

Let first land NFC reformatting part of this patch?
And rebase this patch on top of the NFC one.

Apr 29 2019, 11:09 AM · Restricted Project, Restricted Project
mcgov added a comment to D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.

Ready for review

Apr 29 2019, 10:41 AM · Restricted Project, Restricted Project
mcgov updated the diff for D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.

adding tests for correct behaviors

Apr 29 2019, 10:37 AM · Restricted Project, Restricted Project
mcgov planned changes to D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.
Apr 29 2019, 10:28 AM · Restricted Project, Restricted Project
mcgov created D61268: [AddressSanitizer] [Windows] Fix HeapReAlloc and _recalloc bugs in asan_malloc_win.cc.
Apr 29 2019, 10:20 AM · Restricted Project, Restricted Project

Mar 12 2019

mcgov abandoned D59273: [compiler-rt] Windows: fix crt_initializer.cc test uses wrong pragma to declare crt initializer..

Yep! 100% I made a mistake, the test should remain the same. I'm going to abandon this revision. Thank you for your quick review!

Mar 12 2019, 3:49 PM · Restricted Project, Restricted Project
mcgov planned changes to D59273: [compiler-rt] Windows: fix crt_initializer.cc test uses wrong pragma to declare crt initializer..

Oh wow, good catch. Thank you Reid.

Mar 12 2019, 3:07 PM · Restricted Project, Restricted Project
mcgov added a comment to D59273: [compiler-rt] Windows: fix crt_initializer.cc test uses wrong pragma to declare crt initializer..
Mar 12 2019, 2:22 PM · Restricted Project, Restricted Project
mcgov created D59273: [compiler-rt] Windows: fix crt_initializer.cc test uses wrong pragma to declare crt initializer..
Mar 12 2019, 2:21 PM · Restricted Project, Restricted Project

Mar 1 2019

mcgov abandoned D54581: [compiler-rt] Windows Debug build fix.
Mar 1 2019, 2:39 PM · Restricted Project, Restricted Project
mcgov accepted D58765: [sanitizers] Don't use Windows Trace Logging on MinGW.

Looks good! Thank you for the pointer to the mingw kit, also.

Mar 1 2019, 9:43 AM · Restricted Project, Restricted Project

Feb 28 2019

mcgov added a comment to D58765: [sanitizers] Don't use Windows Trace Logging on MinGW.

@rnk that suggestion works. I'll start testing mingw along with msvc before I commit in the future.

Feb 28 2019, 3:54 PM · Restricted Project, Restricted Project

Feb 27 2019

mcgov committed rG8edffdb4f0fa: [compiler-rt] Windows Trace Logging for error reports. (authored by mcgov).
[compiler-rt] Windows Trace Logging for error reports.
Feb 27 2019, 3:44 PM
mcgov committed rCRT355045: [compiler-rt] Windows Trace Logging for error reports..
[compiler-rt] Windows Trace Logging for error reports.
Feb 27 2019, 3:43 PM
mcgov committed rL355045: [compiler-rt] Windows Trace Logging for error reports..
[compiler-rt] Windows Trace Logging for error reports.
Feb 27 2019, 3:43 PM

Feb 7 2019

mcgov accepted D57339: [compiler rt] Win64 GetInstructionSize additional register MOV + stack alignment AND.
Feb 7 2019, 1:53 PM · Restricted Project, Restricted Project
mcgov updated the diff for D57339: [compiler rt] Win64 GetInstructionSize additional register MOV + stack alignment AND.

Added tests for interception of new functions (just in case).

Feb 7 2019, 1:51 PM · Restricted Project, Restricted Project

Jan 31 2019

mcgov retitled D57339: [compiler rt] Win64 GetInstructionSize additional register MOV + stack alignment AND from [compiler rt] Win64 abi requires additional registers for integer arguments to [compiler rt] Win64 GetInstructionSize additional register MOV + stack alignment AND.
Jan 31 2019, 3:36 PM · Restricted Project, Restricted Project
mcgov updated the diff for D57339: [compiler rt] Win64 GetInstructionSize additional register MOV + stack alignment AND.

Added stack alignment instruction which is common on msvc /Od executables

Jan 31 2019, 3:26 PM · Restricted Project, Restricted Project

Jan 28 2019

mcgov created D57339: [compiler rt] Win64 GetInstructionSize additional register MOV + stack alignment AND.
Jan 28 2019, 9:55 AM · Restricted Project, Restricted Project

Nov 20 2018

mcgov planned changes to D54581: [compiler-rt] Windows Debug build fix.
Nov 20 2018, 9:42 AM · Restricted Project, Restricted Project

Nov 19 2018

mcgov added a comment to D54581: [compiler-rt] Windows Debug build fix.

you can switch this patch into "Plan Changes" state

Nov 19 2018, 2:20 PM · Restricted Project, Restricted Project
mcgov added a comment to D54581: [compiler-rt] Windows Debug build fix.

This needs some more work, I'll ping you all when I have a real fix.

Nov 19 2018, 12:16 PM · Restricted Project, Restricted Project
mcgov added a comment to D54581: [compiler-rt] Windows Debug build fix.
Nov 19 2018, 11:15 AM · Restricted Project, Restricted Project
mcgov updated the diff for D54581: [compiler-rt] Windows Debug build fix.

Fix debug builds by defining a Windows section of the OPERATOR_NEW_BODY macro with the MemalignFromLocalPool call and if condition removed. This section is dead code on Windows, anyway.

Nov 19 2018, 11:13 AM · Restricted Project, Restricted Project
mcgov updated the diff for D54581: [compiler-rt] Windows Debug build fix.

Replaced #define with a function that asserts if called.

Nov 19 2018, 10:41 AM · Restricted Project, Restricted Project

Nov 16 2018

mcgov added a comment to D54581: [compiler-rt] Windows Debug build fix.

And I don't see this code in the r346999

Could you please explain why you need to patch code which is not in the repo?

Nov 16 2018, 1:37 PM · Restricted Project, Restricted Project
mcgov added a comment to D54581: [compiler-rt] Windows Debug build fix.

Fixing to account for Windows and Debug checks.

Nov 16 2018, 9:35 AM · Restricted Project, Restricted Project