User Details
- User Since
- May 24 2018, 10:21 AM (278 w, 13 h)
Jan 10 2023
Mar 3 2021
Can we add @cbezault to this? He's the DevDiv vclibs person who owns Windows ASan going forward
Feb 23 2021
Feb 12 2021
Feb 4 2021
Thank you Vitaly! I'm going to wait on a review from @mstorsjo to land this
nit, style fix
update test to only apply to x64 (we still build x86)
added purge test, updated for Vitaly's comments
Feb 2 2021
Nov 30 2020
lgtm
Sep 24 2020
Sep 15 2020
Sep 4 2020
Sep 3 2020
removed whitespace diff
fixed, break should occur if the env variable is not set OR if there was an error finding the variable, so anytime the return code is 0.
Jan 8 2020
Dec 30 2019
rebased to master
Planning to rebase this patch on master instead of release/9.x
clang formatted the patch
Aug 29 2019
Committed revision 370390.
Committed abac219120d to svn.
git: https://github.com/llvm/llvm-project/commit/11802ccc9ff9348828128202ce91c549cc84a446
Aug 28 2019
Aug 22 2019
Aug 12 2019
Fixed editor! Thank you for the tip :)
Aug 9 2019
update to add !defined(clang)
Jul 15 2019
closing, submitted as commit 08204d2610b095fbddea6959ea6a2fc8a4543ada
scrooched the includes up to fix the typedef issue with size_t
Jul 12 2019
remove commented out work on GlobalAlloc :)
@mrstojo no worries! I'm very new and still learning how to be a good contributor so I appreciate feedback on what I'm doing wrong. I will remove the heapapi include and replace with just the function prototypes I needed along with those constants.
Jul 8 2019
Jul 3 2019
Updating for RNK comments
Just pinging again for review to land this if possible.
Jun 28 2019
updated consexpr and namespace issue
Jun 25 2019
Addressing comments
addressing comments from @vitalybuka
changing macros to constexpr
moving private stuff into asan namespace
Jun 24 2019
Another bump for review from @rnk or @vitalybuka
Jun 21 2019
@vitalybuka Heya, not marking as done but need some feedback from you.
Jun 20 2019
addressing comments from @vitalybuka
Code cleaning, adding comments for clarity
Switches CMake config and environment variable to turn tests on to an ASAN_OPTIONS runtime variable. This makes the activation and testing cleaner, as well as the code itself.
@rnk @vitalybuka @mstorsjo ready for review :)
Jun 19 2019
Modifying to make this option selectable at runtime. This makes it cleaner, without needing config and env var hacks
Jun 10 2019
Jun 6 2019
updating to mask RTL interception from x64 (not supported yet)
Jun 5 2019
Apr 29 2019
closed with revision 359498
fix BYTE typdef and incorrect format
Ready for review (clang-format only applied to new code)
fix call to get_usable_size so that it is not called unless HEAP_ZERO_MEMORY is passed in (the only case when it is needed).
Update diff to only apply clang-format to new code
Ready for review
adding tests for correct behaviors
Mar 12 2019
Yep! 100% I made a mistake, the test should remain the same. I'm going to abandon this revision. Thank you for your quick review!
Oh wow, good catch. Thank you Reid.
Mar 1 2019
Looks good! Thank you for the pointer to the mingw kit, also.
Feb 28 2019
@rnk that suggestion works. I'll start testing mingw along with msvc before I commit in the future.
Feb 27 2019
Feb 7 2019
Added tests for interception of new functions (just in case).