This is an archive of the discontinued LLVM Phabricator instance.

cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON
ClosedPublic

Authored by tstellar on Jul 11 2019, 12:24 PM.

Reviewers

beanz
smeenai

Commits

Summary

If CLANG_LINK_CLANG_DYLIB is also enabled, then this library needs to be
installed.

Fixes PR42575.

LGTM

This revision is now accepted and ready to land.Jul 11 2019, 2:12 PM

LGTM.

This revision was automatically updated to reflect the committed changes.

Path

Size

cfe/

trunk/

tools/

clang-shlib/

5 lines

Show All 32 Lines	foreach (lib ${clang_libs})
# The ideal solution here is to bump our minimum CMake requirement to 3.12,		# The ideal solution here is to bump our minimum CMake requirement to 3.12,
# which adds support for dependencies on object libraries. Until then, linking		# which adds support for dependencies on object libraries. Until then, linking
# both the object and the static libraries seems like the least bad solution.		# both the object and the static libraries seems like the least bad solution.
#		#
# TODO: Rework this when we bump our minimum CMake version to 3.12 or newer.		# TODO: Rework this when we bump our minimum CMake version to 3.12 or newer.
list(APPEND _DEPS ${lib})		list(APPEND _DEPS ${lib})
endforeach ()		endforeach ()

		if (CLANG_LINK_CLANG_DYLIB)
		set(INSTALL_WITH_TOOLCHAIN INSTALL_WITH_TOOLCHAIN)
		endif()

add_clang_library(clang-cpp		add_clang_library(clang-cpp
SHARED		SHARED
		${INSTALL_WITH_TOOLCHAIN}
clang-shlib.cpp		clang-shlib.cpp
${_OBJECTS}		${_OBJECTS}
LINK_LIBS		LINK_LIBS
${_DEPS})		${_DEPS})